From 785fa60cca9e397a7d8eaf3dbc67dad2d0a50170 Mon Sep 17 00:00:00 2001
From: Shannon Booth <shannon@serenityos.org>
Date: Sat, 13 Jan 2024 17:31:46 +1300
Subject: [PATCH] LibWeb: Implement Element.getAttributeNS

---
 .../Text/expected/DOM/Element-getAttributeNS.txt |  4 ++++
 .../Text/input/DOM/Element-getAttributeNS.html   | 16 ++++++++++++++++
 Userland/Libraries/LibWeb/DOM/Element.cpp        | 14 ++++++++++++++
 Userland/Libraries/LibWeb/DOM/Element.h          |  1 +
 Userland/Libraries/LibWeb/DOM/Element.idl        |  1 +
 5 files changed, 36 insertions(+)
 create mode 100644 Tests/LibWeb/Text/expected/DOM/Element-getAttributeNS.txt
 create mode 100644 Tests/LibWeb/Text/input/DOM/Element-getAttributeNS.html

diff --git a/Tests/LibWeb/Text/expected/DOM/Element-getAttributeNS.txt b/Tests/LibWeb/Text/expected/DOM/Element-getAttributeNS.txt
new file mode 100644
index 0000000000..62c9187a37
--- /dev/null
+++ b/Tests/LibWeb/Text/expected/DOM/Element-getAttributeNS.txt
@@ -0,0 +1,4 @@
+     xlink:ref getAttribute = 'null'
+xlink:ref getAttributeNS = 'test'
+href getAttribute = 'test'
+href getAttributeNS = 'null'
diff --git a/Tests/LibWeb/Text/input/DOM/Element-getAttributeNS.html b/Tests/LibWeb/Text/input/DOM/Element-getAttributeNS.html
new file mode 100644
index 0000000000..b2c5d3652b
--- /dev/null
+++ b/Tests/LibWeb/Text/input/DOM/Element-getAttributeNS.html
@@ -0,0 +1,16 @@
+<script src="../include.js"></script>
+<svg xmlns="http://www.w3.org/2000/svg">
+    <script id="with-xlink-href" xlink:href="test"></script>
+    <script id="no-xlink-href" href="test"></script>
+</svg>
+<script id="svg-script-element">
+    test(() => {
+        const xlinkNS = document.getElementById("with-xlink-href");
+        println(`xlink:ref getAttribute = '${xlinkNS.getAttribute("href")}'`);
+        println(`xlink:ref getAttributeNS = '${xlinkNS.getAttributeNS("http://www.w3.org/1999/xlink", "href")}'`);
+
+        const noNS = document.getElementById("no-xlink-href");
+        println(`href getAttribute = '${noNS.getAttribute("href")}'`);
+        println(`href getAttributeNS = '${noNS.getAttributeNS("http://www.w3.org/1999/xlink", "href")}'`);
+    });
+</script>
diff --git a/Userland/Libraries/LibWeb/DOM/Element.cpp b/Userland/Libraries/LibWeb/DOM/Element.cpp
index cdb7e4c6b5..a52f58449c 100644
--- a/Userland/Libraries/LibWeb/DOM/Element.cpp
+++ b/Userland/Libraries/LibWeb/DOM/Element.cpp
@@ -120,6 +120,20 @@ Optional<String> Element::get_attribute(FlyString const& name) const
     return attribute->value();
 }
 
+// https://dom.spec.whatwg.org/#dom-element-getattributens
+Optional<String> Element::get_attribute_ns(Optional<FlyString> const& namespace_, FlyString const& name) const
+{
+    // 1. Let attr be the result of getting an attribute given namespace, localName, and this.
+    auto const* attribute = m_attributes->get_attribute_ns(namespace_, name);
+
+    // 2. If attr is null, return null.
+    if (!attribute)
+        return {};
+
+    // 3. Return attr’s value.
+    return attribute->value();
+}
+
 ByteString Element::deprecated_get_attribute(FlyString const& name) const
 {
     auto maybe_attribute = get_attribute(name);
diff --git a/Userland/Libraries/LibWeb/DOM/Element.h b/Userland/Libraries/LibWeb/DOM/Element.h
index 7c3a0d963e..a4fa22d418 100644
--- a/Userland/Libraries/LibWeb/DOM/Element.h
+++ b/Userland/Libraries/LibWeb/DOM/Element.h
@@ -99,6 +99,7 @@ public:
     Optional<String> attribute(FlyString const& name) const { return get_attribute(name); }
 
     Optional<String> get_attribute(FlyString const& name) const;
+    Optional<String> get_attribute_ns(Optional<FlyString> const& namespace_, FlyString const& name) const;
     ByteString deprecated_get_attribute(FlyString const& name) const;
     String get_attribute_value(FlyString const& local_name, Optional<FlyString> const& namespace_ = {}) const;
 
diff --git a/Userland/Libraries/LibWeb/DOM/Element.idl b/Userland/Libraries/LibWeb/DOM/Element.idl
index 297023feb2..de4a94cd8f 100644
--- a/Userland/Libraries/LibWeb/DOM/Element.idl
+++ b/Userland/Libraries/LibWeb/DOM/Element.idl
@@ -29,6 +29,7 @@ interface Element : Node {
     readonly attribute DOMString tagName;
 
     DOMString? getAttribute(DOMString qualifiedName);
+    DOMString? getAttributeNS([FlyString] DOMString? namespace, [FlyString] DOMString localName);
     [CEReactions] undefined setAttribute(DOMString qualifiedName, DOMString value);
     [CEReactions] undefined setAttributeNS([FlyString] DOMString? namespace , [FlyString] DOMString qualifiedName , DOMString value);
     [CEReactions] Attr? setAttributeNode(Attr attr);