RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 06:08:10 +00:00
Code Issues Activity Actions

LibHTML: Adjust mouse event positions before using them for hit testing

Browse source 
This fixes the issue where you couldn't click on links at the bottom of
scrollable documents. :^)
This commit is contained in:
Andreas Kling 2019-10-03 09:17:27 +02:00
parent a181cae3e0
commit 786494b62d
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibHTML/HtmlView.cpp
View file

@ -88,7 +88,7 @@ void HtmlView::mousemove_event(GMouseEvent& event)
return GScrollableWidget::mousemove_event(event); return GScrollableWidget::mousemove_event(event);
bool hovered_node_changed = false; bool hovered_node_changed = false;
auto result = m_layout_root->hit_test(event.position()); auto result = m_layout_root->hit_test(to_content_position(event.position()));
if (result.layout_node) { if (result.layout_node) {
auto* node = result.layout_node->node(); auto* node = result.layout_node->node();
hovered_node_changed = node != m_document->hovered_node(); hovered_node_changed = node != m_document->hovered_node();
@ -121,7 +121,7 @@ void HtmlView::mousedown_event(GMouseEvent& event)
return GScrollableWidget::mousemove_event(event); return GScrollableWidget::mousemove_event(event);
bool hovered_node_changed = false; bool hovered_node_changed = false;
auto result = m_layout_root->hit_test(event.position()); auto result = m_layout_root->hit_test(to_content_position(event.position()));
if (result.layout_node) { if (result.layout_node) {
auto* node = result.layout_node->node(); auto* node = result.layout_node->node();
hovered_node_changed = node != m_document->hovered_node(); hovered_node_changed = node != m_document->hovered_node();