RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 08:27:45 +00:00
Code Issues Activity Actions

WindowServer: Turn an assertion that happens sometimes into a dbg()

Browse source 
It's very annoying to crash the WindowServer when something harmless
is a little weird.
This commit is contained in:
Andreas Kling 2020-07-07 17:08:51 +02:00
parent 5975a425bd
commit 787673b743
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Services/WindowServer/WindowManager.cpp
View file

@ -395,7 +395,10 @@ void WindowManager::start_window_resize(Window& window, const Gfx::IntPoint& pos
{ ResizeDirection::DownLeft, ResizeDirection::Down, ResizeDirection::DownRight }, { ResizeDirection::DownLeft, ResizeDirection::Down, ResizeDirection::DownRight },
}; };
Gfx::IntRect outer_rect = window.frame().rect(); Gfx::IntRect outer_rect = window.frame().rect();
ASSERT(outer_rect.contains(position)); if (!outer_rect.contains(position)) {
// FIXME: This used to be an ASSERT but crashing WindowServer over this seems silly.
dbg() << "FIXME: !outer_rect.contains(position): outer_rect=" << outer_rect << ", position=" << position;
}
int window_relative_x = position.x() - outer_rect.x(); int window_relative_x = position.x() - outer_rect.x();
int window_relative_y = position.y() - outer_rect.y(); int window_relative_y = position.y() - outer_rect.y();
int hot_area_row = min(2, window_relative_y / (outer_rect.height() / 3)); int hot_area_row = min(2, window_relative_y / (outer_rect.height() / 3));