RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 02:57:44 +00:00
Code Issues Activity Actions

Profiler: Show the name & PID of process being profiled

Browse source 
Also tweak the GUI a little bit to look nicer.
This commit is contained in:
Andreas Kling 2020-12-26 12:58:50 +01:00
parent 1c9d28d212
commit 788594c0c2
1 changed files with 19 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

25
DevTools/Profiler/main.cpp
View file

@ -29,6 +29,7 @@
#include <LibCore/ArgsParser.h> #include <LibCore/ArgsParser.h>
#include <LibCore/ElapsedTimer.h> #include <LibCore/ElapsedTimer.h>
#include <LibCore/EventLoop.h> #include <LibCore/EventLoop.h>
#include <LibCore/ProcessStatisticsReader.h>
#include <LibCore/Timer.h> #include <LibCore/Timer.h>
#include <LibGUI/AboutDialog.h> #include <LibGUI/AboutDialog.h>
#include <LibGUI/Action.h> #include <LibGUI/Action.h>
@ -154,16 +155,18 @@ int main(int argc, char** argv)
return app->exec(); return app->exec();
} }
static bool prompt_to_stop_profiling() static bool prompt_to_stop_profiling(pid_t pid, const String& process_name)
{ {
auto window = GUI::Window::construct(); auto window = GUI::Window::construct();
window->set_title("Profiling"); window->set_title(String::formatted("Profiling {}({})", process_name, pid));
window->resize(320, 200); window->resize(240, 100);
window->set_icon(Gfx::Bitmap::load_from_file("/res/icons/16x16/app-profiler.png")); window->set_icon(Gfx::Bitmap::load_from_file("/res/icons/16x16/app-profiler.png"));
window->center_on_screen(); window->center_on_screen();
auto& widget = window->set_main_widget<GUI::Widget>(); auto& widget = window->set_main_widget<GUI::Widget>();
widget.set_fill_with_background_color(true); widget.set_fill_with_background_color(true);
widget.set_layout<GUI::VerticalBoxLayout>(); auto& layout = widget.set_layout<GUI::VerticalBoxLayout>();
layout.set_margins(GUI::Margins(0, 0, 0, 16));
auto& timer_label = widget.add<GUI::Label>("..."); auto& timer_label = widget.add<GUI::Label>("...");
Core::ElapsedTimer clock; Core::ElapsedTimer clock;
@ -173,6 +176,8 @@ static bool prompt_to_stop_profiling()
}); });
auto& stop_button = widget.add<GUI::Button>("Stop"); auto& stop_button = widget.add<GUI::Button>("Stop");
stop_button.set_size_policy(GUI::SizePolicy::Fixed, GUI::SizePolicy::Fixed);
stop_button.set_preferred_size(140, 22);
stop_button.on_click = [&](auto) { stop_button.on_click = [&](auto) {
GUI::Application::the()->quit(); GUI::Application::the()->quit();
}; };
@ -190,13 +195,21 @@ bool generate_profile(pid_t pid)
pid = process_chooser->pid(); pid = process_chooser->pid();
} }
String process_name;
auto all_processes = Core::ProcessStatisticsReader::get_all();
if (auto it = all_processes.find(pid); it != all_processes.end())
process_name = it->value.name;
else
process_name = "(unknown)";
if (profiling_enable(pid) < 0) { if (profiling_enable(pid) < 0) {
int saved_errno = errno; int saved_errno = errno;
GUI::MessageBox::show(nullptr, String::formatted("Unable to profile PID {}: {}", pid, strerror(saved_errno)), "Profiler", GUI::MessageBox::Type::Error); GUI::MessageBox::show(nullptr, String::formatted("Unable to profile process {}({}): {}", process_name, pid, strerror(saved_errno)), "Profiler", GUI::MessageBox::Type::Error);
return false; return false;
} }
if (!prompt_to_stop_profiling()) if (!prompt_to_stop_profiling(pid, process_name))
return false; return false;
if (profiling_disable(pid) < 0) { if (profiling_disable(pid) < 0) {