RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-15 15:24:57 +00:00
Code Issues Activity Actions

HackStudio: Mark compilation-unit-only functions as static

Browse source 
This also resolves some typing issues that only 'accidentally' worked, like declaring
a function to return type A, and the definition actually returning type B (which works
if type B is a subtype of type A). I like to call these "ninja imports".

To prevent problems like this in the future, I put all globals in a HackStudio.h.
I'm not sure about the name, but main.h and common.h felt wrong.
This commit is contained in:
Ben Wiederhake 2020-08-10 22:28:38 +02:00 • committed by Andreas Kling
parent 42b057b0c9
commit 7893871d5a
7 changed files with 53 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

2
DevTools/HackStudio/Debugger/VariablesModel.cpp
View file

@ -68,7 +68,7 @@ int VariablesModel::row_count(const GUI::ModelIndex& index) const
return node->members.size();
}
String variable_value_as_string(const DebugInfo::VariableInfo& variable)
static String variable_value_as_string(const DebugInfo::VariableInfo& variable)
{
if (variable.location_type != DebugInfo::VariableInfo::LocationType::Address)
return "N/A";