RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-04 17:27:35 +00:00
Code Issues Activity Actions

HackStudio: Mark compilation-unit-only functions as static

Browse source 
This also resolves some typing issues that only 'accidentally' worked, like declaring
a function to return type A, and the definition actually returning type B (which works
if type B is a subtype of type A). I like to call these "ninja imports".

To prevent problems like this in the future, I put all globals in a HackStudio.h.
I'm not sure about the name, but main.h and common.h felt wrong.
This commit is contained in:
Ben Wiederhake 2020-08-10 22:28:38 +02:00 • committed by Andreas Kling
parent 42b057b0c9
commit 7893871d5a
7 changed files with 53 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

5
DevTools/HackStudio/FindInFilesWidget.cpp
View file

@ -25,6 +25,7 @@
*/
#include "FindInFilesWidget.h"
#include "HackStudio.h"
#include "Project.h"
#include <AK/StringBuilder.h>
#include <LibGUI/BoxLayout.h>
@ -32,10 +33,6 @@
#include <LibGUI/TableView.h>
#include <LibGUI/TextBox.h>
extern GUI::TextEditor& current_editor();
extern void open_file(const String&);
extern OwnPtr<Project> g_project;
struct Match {
String filename;
GUI::TextRange range;