RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 09:48:11 +00:00
Code Issues Activity Actions

LibWeb: Remove custom playback timer from HTMLMediaElement

Browse source 
After the EventLoop changes, we do not need to override LibVideo's timer
with a Qt timer for Ladybird. The timer callback provided here also does
not need the JS::SafeFunction wrapper that Platform::Timer provides.
This commit is contained in:
Timothy Flynn 2023-04-25 08:54:04 -04:00 • committed by Andreas Kling
parent e5b97f4a57
commit 78ad471367
1 changed files with 1 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

25
Userland/Libraries/LibWeb/HTML/HTMLMediaElement.cpp
View file

@ -28,31 +28,10 @@
#include <LibWeb/HTML/VideoTrack.h>
#include <LibWeb/HTML/VideoTrackList.h>
#include <LibWeb/MimeSniff/MimeType.h>
#include <LibWeb/Platform/Timer.h>
#include <LibWeb/WebIDL/Promise.h>
namespace Web::HTML {
class MediaElementPlaybackTimer final : public Video::PlaybackTimer {
public:
static ErrorOr<NonnullOwnPtr<MediaElementPlaybackTimer>> create(int interval_ms, Function<void()> timeout_handler)
{
auto timer = Platform::Timer::create_single_shot(interval_ms, move(timeout_handler));
return adopt_nonnull_own_or_enomem(new (nothrow) MediaElementPlaybackTimer(move(timer)));
}
virtual void start() override { m_timer->start(); }
virtual void start(int interval_ms) override { m_timer->start(interval_ms); }
private:
explicit MediaElementPlaybackTimer(NonnullRefPtr<Platform::Timer> timer)
: m_timer(move(timer))
{
}
NonnullRefPtr<Platform::Timer> m_timer;
};
HTMLMediaElement::HTMLMediaElement(DOM::Document& document, DOM::QualifiedName qualified_name)
: HTMLElement(document, move(qualified_name))
, m_pending_play_promises(heap())
@ -773,9 +752,7 @@ WebIDL::ExceptionOr<void> HTMLMediaElement::process_media_data(Function<void(Str
auto& realm = this->realm();
auto& vm = realm.vm();
auto playback_manager = Video::PlaybackManager::from_data(m_media_data, [](auto interval_ms, auto timeout_handler) {
return MediaElementPlaybackTimer::create(interval_ms, move(timeout_handler));
});
auto playback_manager = Video::PlaybackManager::from_data(m_media_data);
// -> If the media data cannot be fetched at all, due to network errors, causing the user agent to give up trying to fetch the resource
// -> If the media data can be fetched but is found by inspection to be in an unsupported format, or can otherwise not be rendered at all