RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 14:38:11 +00:00
Code Issues Activity Actions

Kernel: Propagate HIDManagement initialisation error to init

Browse source 
Initialisation errors for HIDManagement are now returned to the init. In
the init we assert by MUST if we get an error.
This commit is contained in:
Lorenz Steinert 2022-02-23 22:14:09 +01:00 • committed by Andreas Kling
parent d3ce97e8b2
commit 78f8821152
4 changed files with 4 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Kernel/Devices/HID/PS2MouseDevice.cpp
View file

@ -154,7 +154,6 @@ ErrorOr<u8> PS2MouseDevice::send_command(u8 command)
if (response != I8042Response::Acknowledge) {
dbgln("PS2MouseDevice: Command {} got {} but expected ack: {}", command, response, static_cast<u8>(I8042Response::Acknowledge));
// FIXME: Is this the correct errno value for this?
return Error::from_errno(EIO);
}
return response;
@ -165,7 +164,6 @@ ErrorOr<u8> PS2MouseDevice::send_command(u8 command, u8 data)
u8 response = TRY(m_i8042_controller->send_command(instrument_type(), command, data));
if (response != I8042Response::Acknowledge) {
dbgln("PS2MouseDevice: Command {} got {} but expected ack: {}", command, response, static_cast<u8>(I8042Response::Acknowledge));
// FIXME: Is this the correct errno value for this?
return Error::from_errno(EIO);
}
return response;