From 78fbe28070995222a69b40dca71a29d1aa2aad6b Mon Sep 17 00:00:00 2001 From: Tim Ledbetter Date: Tue, 30 May 2023 18:12:00 +0100 Subject: [PATCH] kill: Don't show SIGINVAL or SIGCANCEL in the signal list --- Userland/Utilities/kill.cpp | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/Userland/Utilities/kill.cpp b/Userland/Utilities/kill.cpp index ea54f11831..7e9a6ea11d 100644 --- a/Userland/Utilities/kill.cpp +++ b/Userland/Utilities/kill.cpp @@ -28,10 +28,16 @@ ErrorOr serenity_main(Main::Arguments arguments) auto strings = arguments.strings; if (argc == 2 && strings[1] == "-l") { - for (size_t i = 0; i < NSIG; ++i) { - if (i && !(i % 5)) + size_t valid_signal_count = 0; + for (size_t i = 1; i < NSIG; ++i) { + if (valid_signal_count && valid_signal_count % 5 == 0) outln(""); - out("{:2}) {:10}", i, getsignalname(i)); + auto const* signal_name = getsignalname(i); + // This excludes SIGCANCEL, which is intended for internal use only + if (!signal_name) + continue; + valid_signal_count++; + out("{:2}) {:10}", i, signal_name); } outln(""); return 0;