From 7909475b142af4fa0f099d82e95bc88017d59b04 Mon Sep 17 00:00:00 2001 From: Shannon Booth Date: Sun, 24 Dec 2023 15:39:06 +1300 Subject: [PATCH] LibWeb: Port SVGUseElement from ByteString --- Userland/Libraries/LibWeb/SVG/SVGUseElement.cpp | 4 ++-- Userland/Libraries/LibWeb/SVG/SVGUseElement.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Userland/Libraries/LibWeb/SVG/SVGUseElement.cpp b/Userland/Libraries/LibWeb/SVG/SVGUseElement.cpp index ca8acab023..c14ae56d31 100644 --- a/Userland/Libraries/LibWeb/SVG/SVGUseElement.cpp +++ b/Userland/Libraries/LibWeb/SVG/SVGUseElement.cpp @@ -58,13 +58,13 @@ void SVGUseElement::attribute_changed(FlyString const& name, Optional co m_y = AttributeParser::parse_coordinate(value.value_or(String {})); } else if (name == SVG::AttributeNames::href) { // FIXME: Support the xlink:href attribute as a fallback - m_referenced_id = parse_id_from_href(value.value_or(String {}).to_byte_string()); + m_referenced_id = parse_id_from_href(value.value_or(String {})); clone_element_tree_as_our_shadow_tree(referenced_element()); } } -Optional SVGUseElement::parse_id_from_href(ByteString const& href) +Optional SVGUseElement::parse_id_from_href(StringView href) { auto id_seperator = href.find('#'); if (!id_seperator.has_value()) { diff --git a/Userland/Libraries/LibWeb/SVG/SVGUseElement.h b/Userland/Libraries/LibWeb/SVG/SVGUseElement.h index c768444b56..e7121b5fde 100644 --- a/Userland/Libraries/LibWeb/SVG/SVGUseElement.h +++ b/Userland/Libraries/LibWeb/SVG/SVGUseElement.h @@ -48,7 +48,7 @@ private: virtual JS::GCPtr create_layout_node(NonnullRefPtr) override; - Optional parse_id_from_href(ByteString const& href); + static Optional parse_id_from_href(StringView); JS::GCPtr referenced_element();