RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 06:27:45 +00:00
Code Issues Activity Actions

LibWeb: Reorganize Element::create_layout_node() into a switch

Browse source 
This allows us to see which CSS::Display types are not yet handled.
This commit is contained in:
Andreas Kling 2021-02-07 11:40:42 +01:00
parent e6712fcd82
commit 796c31a52b
1 changed files with 20 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

32
Userland/Libraries/LibWeb/DOM/Element.cpp
View file

@ -120,32 +120,40 @@ RefPtr<Layout::Node> Element::create_layout_node()
if (local_name() == "noscript" && document().is_scripting_enabled()) if (local_name() == "noscript" && document().is_scripting_enabled())
return nullptr; return nullptr;
if (display == CSS::Display::Block) switch (display) {
case CSS::Display::None:
ASSERT_NOT_REACHED();
break;
case CSS::Display::Block:
return adopt(*new Layout::BlockBox(document(), this, move(style))); return adopt(*new Layout::BlockBox(document(), this, move(style)));
case CSS::Display::Inline:
if (display == CSS::Display::Inline) {
if (style->float_().value_or(CSS::Float::None) != CSS::Float::None) if (style->float_().value_or(CSS::Float::None) != CSS::Float::None)
return adopt(*new Layout::BlockBox(document(), this, move(style))); return adopt(*new Layout::BlockBox(document(), this, move(style)));
return adopt(*new Layout::InlineNode(document(), *this, move(style))); return adopt(*new Layout::InlineNode(document(), *this, move(style)));
} case CSS::Display::ListItem:
if (display == CSS::Display::ListItem)
return adopt(*new Layout::ListItemBox(document(), *this, move(style))); return adopt(*new Layout::ListItemBox(document(), *this, move(style)));
if (display == CSS::Display::Table) case CSS::Display::Table:
return adopt(*new Layout::TableBox(document(), this, move(style))); return adopt(*new Layout::TableBox(document(), this, move(style)));
if (display == CSS::Display::TableRow) case CSS::Display::TableRow:
return adopt(*new Layout::TableRowBox(document(), this, move(style))); return adopt(*new Layout::TableRowBox(document(), this, move(style)));
if (display == CSS::Display::TableCell) case CSS::Display::TableCell:
return adopt(*new Layout::TableCellBox(document(), this, move(style))); return adopt(*new Layout::TableCellBox(document(), this, move(style)));
if (display == CSS::Display::TableRowGroup || display == CSS::Display::TableHeaderGroup || display == CSS::Display::TableFooterGroup) case CSS::Display::TableRowGroup:
case CSS::Display::TableHeaderGroup:
case CSS::Display::TableFooterGroup:
return adopt(*new Layout::TableRowGroupBox(document(), *this, move(style))); return adopt(*new Layout::TableRowGroupBox(document(), *this, move(style)));
if (display == CSS::Display::InlineBlock) { case CSS::Display::InlineBlock: {
auto inline_block = adopt(*new Layout::BlockBox(document(), this, move(style))); auto inline_block = adopt(*new Layout::BlockBox(document(), this, move(style)));
inline_block->set_inline(true); inline_block->set_inline(true);
return inline_block; return inline_block;
} }
if (display == CSS::Display::Flex) case CSS::Display::Flex:
return adopt(*new Layout::BlockBox(document(), this, move(style))); return adopt(*new Layout::BlockBox(document(), this, move(style)));
case CSS::Display::TableColumn:
case CSS::Display::TableColumnGroup:
case CSS::Display::TableCaption:
break;
}
ASSERT_NOT_REACHED(); ASSERT_NOT_REACHED();
} }