RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-22 17:15:08 +00:00
Code Issues Activity Actions

LibHTML: Have TreeNode deref its children before deleting itself

Browse source 
This is definitely not the ideal ownership model here, but it's
something we'll have to iterate on as the engine grows.

At least this prevents us from leaking the entire world. :^)
This commit is contained in:
Andreas Kling 2019-10-09 21:58:38 +02:00
parent c458327429
commit 796e63b34c
1 changed files with 12 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Libraries/LibHTML/TreeNode.h
View file

@ -15,8 +15,19 @@ public:
void deref()
{
ASSERT(m_ref_count);
if (!--m_ref_count)
if (!--m_ref_count) {
if (m_next_sibling)
m_next_sibling->m_previous_sibling = m_previous_sibling;
if (m_previous_sibling)
m_previous_sibling->m_next_sibling = m_next_sibling;
T* next_child;
for (auto* child = m_first_child; child; child = next_child) {
next_child = child->m_next_sibling;
child->m_parent = nullptr;
child->deref();
}
delete static_cast<T*>(this);
}
}
int ref_count() const { return m_ref_count; }