mirror of
https://github.com/RGBCube/serenity
synced 2025-07-27 09:07:45 +00:00
LibGUI+Userland: Make TabWidget::*add_tab() take title using new string
This commit is contained in:
parent
5fed25ca9a
commit
797968c310
18 changed files with 59 additions and 59 deletions
|
@ -778,7 +778,7 @@ void HackStudioWidget::add_new_editor_tab_widget(GUI::Widget& parent)
|
|||
|
||||
void HackStudioWidget::add_new_editor(GUI::TabWidget& parent)
|
||||
{
|
||||
auto& wrapper = parent.add_tab<EditorWrapper>("(Untitled)");
|
||||
auto& wrapper = parent.add_tab<EditorWrapper>("(Untitled)"_string.release_value_but_fixme_should_propagate_errors());
|
||||
parent.set_active_widget(&wrapper);
|
||||
if (parent.children().size() > 1 || m_all_editor_tab_widgets.size() > 1)
|
||||
parent.set_close_button_enabled(true);
|
||||
|
@ -978,7 +978,7 @@ ErrorOr<NonnullRefPtr<GUI::Action>> HackStudioWidget::create_add_terminal_action
|
|||
return GUI::Action::create("Add New &Terminal", { Mod_Ctrl | Mod_Alt, Key_T },
|
||||
icon,
|
||||
[this](auto&) {
|
||||
auto& terminal_wrapper = m_action_tab_widget->add_tab<TerminalWrapper>("Terminal");
|
||||
auto& terminal_wrapper = m_action_tab_widget->add_tab<TerminalWrapper>("Terminal"_string.release_value_but_fixme_should_propagate_errors());
|
||||
terminal_wrapper.on_command_exit = [&]() {
|
||||
deferred_invoke([this]() {
|
||||
m_action_tab_widget->remove_tab(*m_action_tab_widget->active_widget());
|
||||
|
@ -1335,24 +1335,24 @@ ErrorOr<void> HackStudioWidget::create_action_tab(GUI::Widget& parent)
|
|||
first_time = false;
|
||||
};
|
||||
|
||||
m_find_in_files_widget = m_action_tab_widget->add_tab<FindInFilesWidget>("Find in files");
|
||||
m_todo_entries_widget = m_action_tab_widget->add_tab<ToDoEntriesWidget>("TODO");
|
||||
m_terminal_wrapper = m_action_tab_widget->add_tab<TerminalWrapper>("Console", false);
|
||||
m_find_in_files_widget = m_action_tab_widget->add_tab<FindInFilesWidget>(TRY("Find in files"_string));
|
||||
m_todo_entries_widget = m_action_tab_widget->add_tab<ToDoEntriesWidget>("TODO"_short_string);
|
||||
m_terminal_wrapper = m_action_tab_widget->add_tab<TerminalWrapper>("Console"_short_string, false);
|
||||
auto debug_info_widget = TRY(DebugInfoWidget::create());
|
||||
TRY(m_action_tab_widget->add_tab(debug_info_widget, "Debug"));
|
||||
TRY(m_action_tab_widget->add_tab(debug_info_widget, "Debug"_short_string));
|
||||
m_debug_info_widget = debug_info_widget;
|
||||
|
||||
m_debug_info_widget->on_backtrace_frame_selection = [this](Debug::DebugInfo::SourcePosition const& source_position) {
|
||||
open_file(get_absolute_path(source_position.file_path), source_position.line_number - 1);
|
||||
};
|
||||
|
||||
m_disassembly_widget = m_action_tab_widget->add_tab<DisassemblyWidget>("Disassembly");
|
||||
m_git_widget = m_action_tab_widget->add_tab<GitWidget>("Git");
|
||||
m_disassembly_widget = m_action_tab_widget->add_tab<DisassemblyWidget>(TRY("Disassembly"_string));
|
||||
m_git_widget = m_action_tab_widget->add_tab<GitWidget>("Git"_short_string);
|
||||
m_git_widget->set_view_diff_callback([this](auto const& original_content, auto const& diff) {
|
||||
m_diff_viewer->set_content(original_content, diff);
|
||||
set_edit_mode(EditMode::Diff);
|
||||
});
|
||||
m_gml_preview_widget = m_action_tab_widget->add_tab<GMLPreviewWidget>("GML Preview", "");
|
||||
m_gml_preview_widget = m_action_tab_widget->add_tab<GMLPreviewWidget>(TRY("GML Preview"_string), "");
|
||||
|
||||
ToDoEntries::the().on_update = [this]() {
|
||||
m_todo_entries_widget->refresh();
|
||||
|
@ -1366,13 +1366,13 @@ void HackStudioWidget::create_project_tab(GUI::Widget& parent)
|
|||
m_project_tab = parent.add<GUI::TabWidget>();
|
||||
m_project_tab->set_tab_position(GUI::TabWidget::TabPosition::Bottom);
|
||||
|
||||
auto& tree_view_container = m_project_tab->add_tab<GUI::Widget>("Files");
|
||||
auto& tree_view_container = m_project_tab->add_tab<GUI::Widget>("Files"_short_string);
|
||||
tree_view_container.set_layout<GUI::VerticalBoxLayout>(GUI::Margins {}, 2);
|
||||
|
||||
m_project_tree_view = tree_view_container.add<GUI::TreeView>();
|
||||
configure_project_tree_view();
|
||||
|
||||
auto& class_view_container = m_project_tab->add_tab<GUI::Widget>("Classes");
|
||||
auto& class_view_container = m_project_tab->add_tab<GUI::Widget>("Classes"_short_string);
|
||||
class_view_container.set_layout<GUI::VerticalBoxLayout>(2);
|
||||
|
||||
m_class_view = class_view_container.add<ClassViewWidget>();
|
||||
|
|
|
@ -131,7 +131,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
|
|||
|
||||
auto tab_widget = TRY(main_splitter->try_add<GUI::TabWidget>());
|
||||
|
||||
auto tree_tab = TRY(tab_widget->try_add_tab<GUI::Widget>("Call Tree"));
|
||||
auto tree_tab = TRY(tab_widget->try_add_tab<GUI::Widget>(TRY("Call Tree"_string)));
|
||||
TRY(tree_tab->try_set_layout<GUI::VerticalBoxLayout>(4));
|
||||
auto bottom_splitter = TRY(tree_tab->try_add<GUI::VerticalSplitter>());
|
||||
|
||||
|
@ -180,7 +180,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
|
|||
update_source_model();
|
||||
});
|
||||
|
||||
auto samples_tab = TRY(tab_widget->try_add_tab<GUI::Widget>("Samples"));
|
||||
auto samples_tab = TRY(tab_widget->try_add_tab<GUI::Widget>(TRY("Samples"_string)));
|
||||
TRY(samples_tab->try_set_layout<GUI::VerticalBoxLayout>(4));
|
||||
|
||||
auto samples_splitter = TRY(samples_tab->try_add<GUI::HorizontalSplitter>());
|
||||
|
@ -194,7 +194,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
|
|||
individual_sample_view->set_model(move(model));
|
||||
};
|
||||
|
||||
auto signposts_tab = TRY(tab_widget->try_add_tab<GUI::Widget>("Signposts"));
|
||||
auto signposts_tab = TRY(tab_widget->try_add_tab<GUI::Widget>(TRY("Signposts"_string)));
|
||||
TRY(signposts_tab->try_set_layout<GUI::VerticalBoxLayout>(4));
|
||||
|
||||
auto signposts_splitter = TRY(signposts_tab->try_add<GUI::HorizontalSplitter>());
|
||||
|
@ -208,7 +208,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
|
|||
individual_signpost_view->set_model(move(model));
|
||||
};
|
||||
|
||||
auto flamegraph_tab = TRY(tab_widget->try_add_tab<GUI::Widget>("Flame Graph"));
|
||||
auto flamegraph_tab = TRY(tab_widget->try_add_tab<GUI::Widget>(TRY("Flame Graph"_string)));
|
||||
TRY(flamegraph_tab->try_set_layout<GUI::VerticalBoxLayout>(GUI::Margins { 4, 4, 4, 4 }));
|
||||
|
||||
auto flamegraph_view = TRY(flamegraph_tab->try_add<FlameGraphView>(profile->model(), ProfileModel::Column::StackFrame, ProfileModel::Column::SampleCount));
|
||||
|
@ -256,7 +256,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
|
|||
timeline_view->on_selection_change = [&] { statusbar_update(); };
|
||||
flamegraph_view->on_hover_change = [&] { statusbar_update(); };
|
||||
|
||||
auto filesystem_events_tab = TRY(tab_widget->try_add_tab<GUI::Widget>("Filesystem events"));
|
||||
auto filesystem_events_tab = TRY(tab_widget->try_add_tab<GUI::Widget>(TRY("Filesystem events"_string)));
|
||||
TRY(filesystem_events_tab->try_set_layout<GUI::VerticalBoxLayout>(4));
|
||||
|
||||
auto filesystem_events_tree_view = TRY(filesystem_events_tab->try_add<GUI::TreeView>());
|
||||
|
|
|
@ -226,7 +226,7 @@ MainWidget::MainWidget()
|
|||
|
||||
m_action_tab_widget = find_descendant_of_type_named<GUI::TabWidget>("action_tab_widget"sv);
|
||||
|
||||
m_query_results_widget = m_action_tab_widget->add_tab<GUI::Widget>("Results");
|
||||
m_query_results_widget = m_action_tab_widget->add_tab<GUI::Widget>("Results"_short_string);
|
||||
m_query_results_widget->set_layout<GUI::VerticalBoxLayout>(6);
|
||||
m_query_results_table_view = m_query_results_widget->add<GUI::TableView>();
|
||||
|
||||
|
@ -327,7 +327,7 @@ void MainWidget::open_new_script()
|
|||
auto new_script_name = DeprecatedString::formatted("New Script - {}", m_new_script_counter);
|
||||
++m_new_script_counter;
|
||||
|
||||
auto& editor = m_tab_widget->add_tab<ScriptEditor>(new_script_name);
|
||||
auto& editor = m_tab_widget->add_tab<ScriptEditor>(String::from_deprecated_string(new_script_name).release_value_but_fixme_should_propagate_errors());
|
||||
editor.new_script_with_temp_name(new_script_name);
|
||||
|
||||
editor.on_cursor_change = [this] { on_editor_change(); };
|
||||
|
@ -339,7 +339,7 @@ void MainWidget::open_new_script()
|
|||
|
||||
void MainWidget::open_script_from_file(LexicalPath const& file_path)
|
||||
{
|
||||
auto& editor = m_tab_widget->add_tab<ScriptEditor>(file_path.title());
|
||||
auto& editor = m_tab_widget->add_tab<ScriptEditor>(String::from_deprecated_string(file_path.title()).release_value_but_fixme_should_propagate_errors());
|
||||
|
||||
if (auto result = editor.open_script_from_file(file_path); result.is_error()) {
|
||||
GUI::MessageBox::show_error(window(), DeprecatedString::formatted("Failed to open {}\n{}", file_path, result.error()));
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue