RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 18:47:44 +00:00
Code Issues Activity Actions

LibWeb: Add 'should block pop ups' user config to Page

Browse source 
This will also be used by the window.open algorithm steps.
This commit is contained in:
Idan Horowitz 2022-11-15 02:01:13 +02:00 • committed by Linus Groh
parent ff2f31bc81
commit 798d7c6fae
3 changed files with 17 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Applications/Browser/BrowserWindow.cpp
View file

@ -430,6 +430,14 @@ void BrowserWindow::build_menus()
scripting_enabled_action->set_checked(true); scripting_enabled_action->set_checked(true);
debug_menu.add_action(scripting_enabled_action); debug_menu.add_action(scripting_enabled_action);
auto block_pop_ups_action = GUI::Action::create_checkable(
"Block Pop-ups", [this](auto& action) {
active_tab().view().debug_request("block-pop-ups", action.is_checked() ? "on" : "off");
},
this);
block_pop_ups_action->set_checked(true);
debug_menu.add_action(block_pop_ups_action);
auto same_origin_policy_action = GUI::Action::create_checkable( auto same_origin_policy_action = GUI::Action::create_checkable(
"Enable Same Origin &Policy", [this](auto& action) { "Enable Same Origin &Policy", [this](auto& action) {
active_tab().view().debug_request("same-origin-policy", action.is_checked() ? "on" : "off"); active_tab().view().debug_request("same-origin-policy", action.is_checked() ? "on" : "off");

5
Userland/Libraries/LibWeb/Page/Page.h
View file

@ -71,6 +71,9 @@ public:
bool is_scripting_enabled() const { return m_is_scripting_enabled; } bool is_scripting_enabled() const { return m_is_scripting_enabled; }
void set_is_scripting_enabled(bool b) { m_is_scripting_enabled = b; } void set_is_scripting_enabled(bool b) { m_is_scripting_enabled = b; }
bool should_block_pop_ups() const { return m_should_block_pop_ups; }
void set_should_block_pop_ups(bool b) { m_should_block_pop_ups = b; }
bool is_webdriver_active() const { return m_is_webdriver_active; } bool is_webdriver_active() const { return m_is_webdriver_active; }
void set_is_webdriver_active(bool b) { m_is_webdriver_active = b; } void set_is_webdriver_active(bool b) { m_is_webdriver_active = b; }
@ -91,6 +94,8 @@ private:
bool m_is_scripting_enabled { true }; bool m_is_scripting_enabled { true };
bool m_should_block_pop_ups { true };
// https://w3c.github.io/webdriver/#dfn-webdriver-active-flag // https://w3c.github.io/webdriver/#dfn-webdriver-active-flag
// The webdriver-active flag is set to true when the user agent is under remote control. It is initially false. // The webdriver-active flag is set to true when the user agent is under remote control. It is initially false.
bool m_is_webdriver_active { false }; bool m_is_webdriver_active { false };

4
Userland/Services/WebContent/ConnectionFromClient.cpp
View file

@ -248,6 +248,10 @@ void ConnectionFromClient::debug_request(String const& request, String const& ar
m_page_host->page().set_is_scripting_enabled(argument == "on"); m_page_host->page().set_is_scripting_enabled(argument == "on");
} }
if (request == "block-pop-ups") {
m_page_host->page().set_should_block_pop_ups(argument == "on");
}
if (request == "dump-local-storage") { if (request == "dump-local-storage") {
if (auto* doc = page().top_level_browsing_context().active_document()) if (auto* doc = page().top_level_browsing_context().active_document())
doc->window().local_storage()->dump(); doc->window().local_storage()->dump();