From 79b73b7fbbd7263311a7ec60d5f00a927d5158d9 Mon Sep 17 00:00:00 2001 From: Aliaksandr Kalenik Date: Thu, 1 Feb 2024 14:50:53 +0100 Subject: [PATCH] LibWeb: Use Window::scroll() in Element::set_scroll_top() Now when Window::scroll() could do actual scrolling we can remove this FIXME. --- Userland/Libraries/LibWeb/DOM/Element.cpp | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/Userland/Libraries/LibWeb/DOM/Element.cpp b/Userland/Libraries/LibWeb/DOM/Element.cpp index ec16cbcf5e..f6605b55c8 100644 --- a/Userland/Libraries/LibWeb/DOM/Element.cpp +++ b/Userland/Libraries/LibWeb/DOM/Element.cpp @@ -1299,17 +1299,13 @@ void Element::set_scroll_top(double y) // 8. If the element is the root element invoke scroll() on window with scrollX on window as first argument and y as second argument, and terminate these steps. if (document.document_element() == this) { - // FIXME: Implement this in terms of invoking scroll() on window. - if (document.browsing_context() == &document.page().top_level_browsing_context()) - document.page().client().page_did_request_scroll_to({ static_cast(window->scroll_x()), static_cast(y) }); + window->scroll(window->scroll_x(), y); return; } // 9. If the element is the body element, document is in quirks mode, and the element is not potentially scrollable, invoke scroll() on window with scrollX as first argument and y as second argument, and terminate these steps. if (document.body() == this && document.in_quirks_mode() && !is_potentially_scrollable()) { - // FIXME: Implement this in terms of invoking scroll() on window. - if (document.browsing_context() == &document.page().top_level_browsing_context()) - document.page().client().page_did_request_scroll_to({ static_cast(window->scroll_x()), static_cast(y) }); + window->scroll(window->scroll_x(), y); return; }