RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 07:07:34 +00:00
Code Issues Activity Actions

LibWeb: Rename PaintableBox::effective_offset() => offset()

Browse source 
Since this function no longer does any computation, just "offset" seems
like a fine name.
This commit is contained in:
Andreas Kling 2023-08-15 15:42:38 +02:00
parent 25a3d0d643
commit 79db9c27c6
3 changed files with 8 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWeb/Painting/PaintableBox.cpp
View file

@ -115,16 +115,16 @@ void PaintableBox::set_content_size(CSSPixelSize size)
layout_box().did_set_content_size(); layout_box().did_set_content_size();
} }
CSSPixelPoint PaintableBox::effective_offset() const CSSPixelPoint PaintableBox::offset() const
{ {
return m_offset; return m_offset;
} }
CSSPixelRect PaintableBox::compute_absolute_rect() const CSSPixelRect PaintableBox::compute_absolute_rect() const
{ {
CSSPixelRect rect { effective_offset(), content_size() }; CSSPixelRect rect { offset(), content_size() };
for (auto const* block = containing_block(); block && block->paintable(); block = block->paintable()->containing_block()) for (auto const* block = containing_block(); block && block->paintable(); block = block->paintable()->containing_block())
rect.translate_by(block->paintable_box()->effective_offset()); rect.translate_by(block->paintable_box()->offset());
return rect; return rect;
} }

4
Userland/Libraries/LibWeb/Painting/PaintableBox.h
View file

@ -36,7 +36,9 @@ public:
}; };
CSSPixelRect absolute_rect() const; CSSPixelRect absolute_rect() const;
CSSPixelPoint effective_offset() const;
// Offset from the top left of the containing block's content edge.
[[nodiscard]] CSSPixelPoint offset() const;
CSSPixelPoint scroll_offset() const; CSSPixelPoint scroll_offset() const;
void set_scroll_offset(CSSPixelPoint); void set_scroll_offset(CSSPixelPoint);

4
Userland/Libraries/LibWeb/Painting/SVGPaintable.cpp
View file

@ -23,9 +23,9 @@ Layout::SVGBox const& SVGPaintable::layout_box() const
CSSPixelRect SVGPaintable::compute_absolute_rect() const CSSPixelRect SVGPaintable::compute_absolute_rect() const
{ {
if (auto* svg_svg_box = layout_box().first_ancestor_of_type<Layout::SVGSVGBox>()) { if (auto* svg_svg_box = layout_box().first_ancestor_of_type<Layout::SVGSVGBox>()) {
CSSPixelRect rect { effective_offset(), content_size() }; CSSPixelRect rect { offset(), content_size() };
for (Layout::Box const* ancestor = svg_svg_box; ancestor && ancestor->paintable(); ancestor = ancestor->paintable()->containing_block()) for (Layout::Box const* ancestor = svg_svg_box; ancestor && ancestor->paintable(); ancestor = ancestor->paintable()->containing_block())
rect.translate_by(ancestor->paintable_box()->effective_offset()); rect.translate_by(ancestor->paintable_box()->offset());
return rect; return rect;
} }
return PaintableBox::compute_absolute_rect(); return PaintableBox::compute_absolute_rect();