RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 15:28:11 +00:00
Code Issues Activity Actions

Kernel: Make File::write() and File::read() return KResultOr<size_t>

Browse source 
Instead of returning a ssize_t where negative values mean error,
we now return KResultOr<size_t> and use the error state to report
errors exclusively.
This commit is contained in:
Andreas Kling 2020-08-04 18:02:23 +02:00
parent 58feebeed2
commit 7a3ab6c517
58 changed files with 223 additions and 229 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Kernel/Devices/RandomDevice.cpp
View file

@ -43,16 +43,16 @@ bool RandomDevice::can_read(const FileDescription&, size_t) const
return true;
}
ssize_t RandomDevice::read(FileDescription&, size_t, u8* buffer, ssize_t size)
KResultOr<size_t> RandomDevice::read(FileDescription&, size_t, u8* buffer, size_t size)
{
get_good_random_bytes(buffer, size);
return size;
}
ssize_t RandomDevice::write(FileDescription&, size_t, const u8*, ssize_t size)
KResultOr<size_t> RandomDevice::write(FileDescription&, size_t, const u8*, size_t size)
{
// FIXME: Use input for entropy? I guess that could be a neat feature?
return min(static_cast<ssize_t>(PAGE_SIZE), size);
return min(static_cast<size_t>(PAGE_SIZE), size);
}
}