RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 14:07:45 +00:00
Code Issues Activity Actions

LibJS: Add some assertions and tests for TypedArray limitations

Browse source
This commit is contained in:
Andreas Kling 2021-01-24 18:52:57 +01:00
parent 0e3ee03e2b
commit 7a71d4b887
2 changed files with 21 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibJS/Runtime/TypedArray.h
View file

@ -132,7 +132,10 @@ protected:
TypedArray(u32 array_length, Object& prototype) TypedArray(u32 array_length, Object& prototype)
: TypedArrayBase(prototype) : TypedArrayBase(prototype)
{ {
ASSERT(!Checked<u32>::multiplication_would_overflow(array_length, sizeof(T)));
m_viewed_array_buffer = ArrayBuffer::create(global_object(), array_length * sizeof(T)); m_viewed_array_buffer = ArrayBuffer::create(global_object(), array_length * sizeof(T));
if (array_length)
ASSERT(data() != nullptr);
m_array_length = array_length; m_array_length = array_length;
m_byte_length = m_viewed_array_buffer->byte_length(); m_byte_length = m_viewed_array_buffer->byte_length();
} }

18
Userland/Libraries/LibJS/Tests/builtins/TypedArray/typed-array-limits.js Normal file
View file

@ -0,0 +1,18 @@
test("some oversized typed arrays", () => {
expect(() => new Uint8Array(2 * 1024 * 1024 * 1024)).toThrowWithMessage(
RangeError,
"Invalid typed array length"
);
expect(() => new Uint16Array(2 * 1024 * 1024 * 1024)).toThrowWithMessage(
RangeError,
"Invalid typed array length"
);
expect(() => new Uint32Array(1024 * 1024 * 1024)).toThrowWithMessage(
RangeError,
"Invalid typed array length"
);
expect(() => new Uint32Array(4 * 1024 * 1024 * 1024)).toThrowWithMessage(
RangeError,
"Invalid typed array length"
);
});