RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 10:48:11 +00:00
Code Issues Activity Actions

LibWeb: Cache the <body background> style image value

Browse source 
This way we don't refetch the background image every time style is
recomputed (e.g when hovering different elements.)
This commit is contained in:
Andreas Kling 2020-03-07 11:17:18 +01:00
parent 8f25dbf394
commit 7a9cb2dfca
2 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Libraries/LibWeb/DOM/HTMLBodyElement.cpp
View file

@ -52,7 +52,8 @@ void HTMLBodyElement::apply_presentational_hints(StyleProperties& style) const
if (color.has_value()) if (color.has_value())
style.set_property(CSS::PropertyID::Color, ColorStyleValue::create(color.value())); style.set_property(CSS::PropertyID::Color, ColorStyleValue::create(color.value()));
} else if (name.equals_ignoring_case("background")) { } else if (name.equals_ignoring_case("background")) {
style.set_property(CSS::PropertyID::BackgroundImage, ImageStyleValue::create(document().complete_url(value), const_cast<Document&>(document()))); ASSERT(m_background_style_value);
style.set_property(CSS::PropertyID::BackgroundImage, *m_background_style_value);
} }
}); });
} }
@ -71,6 +72,8 @@ void HTMLBodyElement::parse_attribute(const String& name, const String& value)
auto color = Color::from_string(value); auto color = Color::from_string(value);
if (color.has_value()) if (color.has_value())
document().set_visited_link_color(color.value()); document().set_visited_link_color(color.value());
} else if (name.equals_ignoring_case("background")) {
m_background_style_value = ImageStyleValue::create(document().complete_url(value), const_cast<Document&>(document()));
} }
} }

3
Libraries/LibWeb/DOM/HTMLBodyElement.h
View file

@ -37,6 +37,9 @@ public:
virtual void parse_attribute(const String&, const String&) override; virtual void parse_attribute(const String&, const String&) override;
virtual void apply_presentational_hints(StyleProperties&) const override; virtual void apply_presentational_hints(StyleProperties&) const override;
private:
RefPtr<ImageStyleValue> m_background_style_value;
}; };
template<> template<>