From 7aa5a2bc0f35c1874859a172f2a0d3708e969984 Mon Sep 17 00:00:00 2001
From: AnotherTest <ali.mpfard@gmail.com>
Date: Wed, 12 Aug 2020 01:13:32 +0430
Subject: [PATCH] Shell: Eliminate possible use-after-free in builtin_fg()

This fixes a possible UAF where the job might be destroyed in
block_on_job().
---
 Shell/Builtin.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Shell/Builtin.cpp b/Shell/Builtin.cpp
index 9ca91a71ee..e23588dbf0 100644
--- a/Shell/Builtin.cpp
+++ b/Shell/Builtin.cpp
@@ -332,7 +332,7 @@ int Shell::builtin_fg(int argc, const char** argv)
     if (job_id == -1 && !jobs.is_empty())
         job_id = find_last_job_id();
 
-    auto* job = const_cast<Job*>(find_job(job_id));
+    RefPtr<Job> job = find_job(job_id);
 
     if (!job) {
         if (job_id == -1) {