RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 08:38:12 +00:00
Code Issues Activity Actions

LibWeb: Remove BrowsingContext::scroll_to()

Browse source 
Let's use navigable directly instead of going through browsing context
to request a scroll.
This commit is contained in:
Aliaksandr Kalenik 2024-02-03 11:26:14 +01:00 • committed by Andreas Kling
parent 0c92c80544
commit 7ad0767aa0
3 changed files with 2 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Userland/Libraries/LibWeb/HTML/BrowsingContext.cpp
View file

@ -343,19 +343,6 @@ bool BrowsingContext::is_focused_context() const
return &m_page->focused_context() == this;
}
void BrowsingContext::scroll_to(CSSPixelPoint position)
{
// NOTE: Scrolling to a position requires up-to-date layout *unless* we're scrolling to (0, 0)
// as (0, 0) is always guaranteed to be a valid scroll position.
if (!position.is_zero()) {
if (active_document())
active_document()->update_layout();
}
if (auto navigable = active_document()->navigable())
navigable->perform_scroll_of_viewport(position);
}
JS::GCPtr<BrowsingContext> BrowsingContext::top_level_browsing_context() const
{
auto const* start = this;