From 7b3559f1c2af9d3ce8c78ca1c0cfad23e04a8429 Mon Sep 17 00:00:00 2001 From: Aliaksandr Kalenik Date: Sat, 18 Nov 2023 14:46:24 +0100 Subject: [PATCH] LibWeb: Remove `navigate()` in `EventHandler::handle_mouseup()` Before this change `navigate()` was always invoked twice when a link is clicked: - From `activation_behavior` callback of `HTMLAnchorElement` during event dispatch. - Directly from `handle_mouseup`. --- Userland/Libraries/LibWeb/Page/EventHandler.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/Userland/Libraries/LibWeb/Page/EventHandler.cpp b/Userland/Libraries/LibWeb/Page/EventHandler.cpp index 73e0e80022..11b7418b70 100644 --- a/Userland/Libraries/LibWeb/Page/EventHandler.cpp +++ b/Userland/Libraries/LibWeb/Page/EventHandler.cpp @@ -284,9 +284,7 @@ bool EventHandler::handle_mouseup(CSSPixelPoint position, CSSPixelPoint screen_p auto href = link->href(); auto url = document->parse_url(href); dbgln("Web::EventHandler: Clicking on a link to {}", url); - if (button == GUI::MouseButton::Primary) { - MUST(document->navigable()->navigate({ .url = url, .source_document = document })); - } else if (button == GUI::MouseButton::Middle) { + if (button == GUI::MouseButton::Middle) { if (auto* page = m_browsing_context->page()) page->client().page_did_middle_click_link(url, link->target(), modifiers); } else if (button == GUI::MouseButton::Secondary) {