RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 18:18:12 +00:00
Code Issues Activity Actions

LibJS: Convert IteratorValue AO to ThrowCompletionOr

Browse source
This commit is contained in:
Timothy Flynn 2021-10-20 09:05:52 -04:00 • committed by Linus Groh
parent a64752cd34
commit 7b4814f74c
8 changed files with 20 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Userland/Libraries/LibJS/Bytecode/Op.cpp
View file

@ -134,7 +134,6 @@ void NewArray::execute_impl(Bytecode::Interpreter& interpreter) const
void IteratorToArray::execute_impl(Bytecode::Interpreter& interpreter) const
{
auto& global_object = interpreter.global_object();
auto& vm = interpreter.vm();
auto iterator_or_error = interpreter.accumulator().to_object(global_object);
if (iterator_or_error.is_error())
return;
@ -159,9 +158,10 @@ void IteratorToArray::execute_impl(Bytecode::Interpreter& interpreter) const
return;
}
auto value = iterator_value(global_object, *iterator_result);
if (vm.exception())
auto value_or_error = iterator_value(global_object, *iterator_result);
if (value_or_error.is_error())
return;
auto value = value_or_error.release_value();
MUST(array->create_data_property_or_throw(index, value));
index++;
@ -522,7 +522,13 @@ void IteratorResultValue::execute_impl(Bytecode::Interpreter& interpreter) const
if (iterator_result_or_error.is_error())
return;
auto* iterator_result = iterator_result_or_error.release_value();
interpreter.accumulator() = iterator_value(interpreter.global_object(), *iterator_result);
auto value_or_error = iterator_value(interpreter.global_object(), *iterator_result);
if (value_or_error.is_error())
return;
auto value = value_or_error.release_value();
interpreter.accumulator() = value;
}
void NewClass::execute_impl(Bytecode::Interpreter&) const