RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 17:17:44 +00:00
Code Issues Activity Actions

LibVT: Store all-ASCII terminal lines as 8-bit characters

Browse source 
To conserve memory, we now use byte storage for terminal lines until we
encounter a non-ASCII codepoint. At that point, we transparently switch
to UTF-32 storage for that one line.
This commit is contained in:
Andreas Kling 2020-05-17 11:32:31 +02:00
parent a398898c12
commit 7b5b4bee70
4 changed files with 78 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Libraries/LibVT/Terminal.cpp
View file

@ -528,11 +528,11 @@ void Terminal::escape$P(const ParamVector& params)
// Move n characters of line to the left
for (int i = m_cursor_column; i < line.length() - num; i++)
line.codepoints()[i] = line.codepoints()[i + num];
line.set_codepoint(i, line.codepoint(i + num));
// Fill remainder of line with blanks
for (int i = line.length() - num; i < line.length(); i++)
line.codepoints()[i] = ' ';
line.set_codepoint(i, ' ');
line.set_dirty(true);
}
@ -760,17 +760,17 @@ void Terminal::set_cursor(unsigned a_row, unsigned a_column)
invalidate_cursor();
}
void Terminal::put_character_at(unsigned row, unsigned column, u32 ch)
void Terminal::put_character_at(unsigned row, unsigned column, u32 codepoint)
{
ASSERT(row < rows());
ASSERT(column < columns());
auto& line = m_lines[row];
line.codepoints()[column] = ch;
line.set_codepoint(column, codepoint);
line.attributes()[column] = m_current_attribute;
line.attributes()[column].flags |= Attribute::Touched;
line.set_dirty(true);
m_last_codepoint = ch;
m_last_codepoint = codepoint;
}
void Terminal::NEL()