RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 02:47:34 +00:00
Code Issues Activity Actions

LibJS: Make the Function() constructor throw a SyntaxError, not return

Browse source
This commit is contained in:
Linus Groh 2020-05-13 01:09:49 +01:00 • committed by Andreas Kling
parent aab998e776
commit 7b8765c311
2 changed files with 8 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Libraries/LibJS/Runtime/FunctionConstructor.cpp
View file

@ -71,7 +71,8 @@ Value FunctionConstructor::construct(Interpreter& interpreter)
auto function_expression = parser.parse_function_node<FunctionExpression>();
if (parser.has_errors()) {
// FIXME: The parser should expose parsing error strings rather than just fprintf()'ing them
return Error::create(interpreter.global_object(), "SyntaxError", "");
interpreter.throw_exception<SyntaxError>("");
return {};
}
return function_expression->execute(interpreter);
}

6
Libraries/LibJS/Tests/Function.js
View file

@ -26,6 +26,12 @@ try {
assert(new Function().name === "anonymous");
assert(new Function().toString() === "function anonymous() {\n ???\n}");
assertThrowsError(() => {
new Function("[");
}, {
error: SyntaxError
});
console.log("PASS");
} catch (e) {
console.log("FAIL: " + e.message);