RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 18:47:34 +00:00
Code Issues Activity Actions

LibCore+Ladybird: Add EventLoopManager interface for persistent state

Browse source 
Things such as timers and notifiers aren't specific to one instance of
Core::EventLoop, so let's not tie them down to EventLoopImplementation.

Instead, move those APIs + signals & a few other things to a new
EventLoopManager interface. EventLoopManager also knows how to create a
new EventLoopImplementation object.
This commit is contained in:
Andreas Kling 2023-04-25 17:38:48 +02:00
parent c21eb30a2b
commit 7b963e1e98
11 changed files with 177 additions and 118 deletions
Download patch file Download diff file Expand all files Collapse all files

39
Userland/Libraries/LibCore/EventLoop.cpp
View file

@ -24,16 +24,10 @@ Vector<EventLoop&>& event_loop_stack()
s_event_loop_stack = new Vector<EventLoop&>;
return *s_event_loop_stack;
}
bool has_event_loop()
{
return !event_loop_stack().is_empty();
}
}
Function<NonnullOwnPtr<EventLoopImplementation>()> EventLoop::make_implementation = EventLoopImplementationUnix::create;
EventLoop::EventLoop()
: m_impl(make_implementation())
: m_impl(EventLoopManager::the().make_implementation())
{
if (event_loop_stack().is_empty()) {
event_loop_stack().append(*this);
@ -94,7 +88,7 @@ size_t EventLoop::pump(WaitMode mode)
void EventLoop::post_event(Object& receiver, NonnullOwnPtr<Event>&& event)
{
m_impl->post_event(receiver, move(event));
EventLoopManager::the().post_event(receiver, move(event));
}
void EventLoop::add_job(NonnullRefPtr<Promise<NonnullRefPtr<Object>>> job_promise)
@ -104,16 +98,12 @@ void EventLoop::add_job(NonnullRefPtr<Promise<NonnullRefPtr<Object>>> job_promis
int EventLoop::register_signal(int signal_number, Function<void(int)> handler)
{
if (!has_event_loop())
return 0;
return current().m_impl->register_signal(signal_number, move(handler));
return EventLoopManager::the().register_signal(signal_number, move(handler));
}
void EventLoop::unregister_signal(int handler_id)
{
if (!has_event_loop())
return;
current().m_impl->unregister_signal(handler_id);
EventLoopManager::the().unregister_signal(handler_id);
}
void EventLoop::notify_forked(ForkEvent)
@ -123,30 +113,22 @@ void EventLoop::notify_forked(ForkEvent)
int EventLoop::register_timer(Object& object, int milliseconds, bool should_reload, TimerShouldFireWhenNotVisible fire_when_not_visible)
{
if (!has_event_loop())
return 0;
return current().m_impl->register_timer(object, milliseconds, should_reload, fire_when_not_visible);
return EventLoopManager::the().register_timer(object, milliseconds, should_reload, fire_when_not_visible);
}
bool EventLoop::unregister_timer(int timer_id)
{
if (!has_event_loop())
return false;
return current().m_impl->unregister_timer(timer_id);
return EventLoopManager::the().unregister_timer(timer_id);
}
void EventLoop::register_notifier(Badge<Notifier>, Notifier& notifier)
{
if (!has_event_loop())
return;
current().m_impl->register_notifier(notifier);
EventLoopManager::the().register_notifier(notifier);
}
void EventLoop::unregister_notifier(Badge<Notifier>, Notifier& notifier)
{
if (!has_event_loop())
return;
current().m_impl->unregister_notifier(notifier);
EventLoopManager::the().unregister_notifier(notifier);
}
void EventLoop::wake()
@ -170,9 +152,4 @@ bool EventLoop::was_exit_requested() const
return m_impl->was_exit_requested();
}
void EventLoop::did_post_event(Badge<Core::ThreadEventQueue>)
{
m_impl->did_post_event();
}
}