RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 23:17:45 +00:00
Code Issues Activity Actions

LibCore+Ladybird: Add EventLoopManager interface for persistent state

Browse source 
Things such as timers and notifiers aren't specific to one instance of
Core::EventLoop, so let's not tie them down to EventLoopImplementation.

Instead, move those APIs + signals & a few other things to a new
EventLoopManager interface. EventLoopManager also knows how to create a
new EventLoopImplementation object.
This commit is contained in:
Andreas Kling 2023-04-25 17:38:48 +02:00
parent c21eb30a2b
commit 7b963e1e98
11 changed files with 177 additions and 118 deletions
Download patch file Download diff file Expand all files Collapse all files

48
Userland/Libraries/LibCore/EventLoopImplementation.h
View file

@ -11,8 +11,40 @@
namespace Core {
class EventLoopImplementation;
class ThreadEventQueue;
class EventLoopManager {
public:
static EventLoopManager& the();
static void install(EventLoopManager&);
virtual ~EventLoopManager();
virtual NonnullOwnPtr<EventLoopImplementation> make_implementation() = 0;
virtual int register_timer(Object&, int milliseconds, bool should_reload, TimerShouldFireWhenNotVisible) = 0;
virtual bool unregister_timer(int timer_id) = 0;
virtual void register_notifier(Notifier&) = 0;
virtual void unregister_notifier(Notifier&) = 0;
void post_event(Object& receiver, NonnullOwnPtr<Event>&&);
virtual void did_post_event() = 0;
virtual void deferred_invoke(Function<void()>) = 0;
// FIXME: These APIs only exist for obscure use-cases inside SerenityOS. Try to get rid of them.
virtual int register_signal(int signal_number, Function<void(int)> handler) = 0;
virtual void unregister_signal(int handler_id) = 0;
virtual void wake() = 0;
protected:
EventLoopManager();
ThreadEventQueue& m_thread_event_queue;
};
class EventLoopImplementation {
public:
virtual ~EventLoopImplementation();
@ -22,34 +54,18 @@ public:
DontWaitForEvents,
};
void post_event(Object& receiver, NonnullOwnPtr<Event>&&);
virtual int exec() = 0;
virtual size_t pump(PumpMode) = 0;
virtual void quit(int) = 0;
virtual void wake() = 0;
virtual void deferred_invoke(Function<void()>) = 0;
virtual int register_timer(Object&, int milliseconds, bool should_reload, TimerShouldFireWhenNotVisible) = 0;
virtual bool unregister_timer(int timer_id) = 0;
virtual void register_notifier(Notifier&) = 0;
virtual void unregister_notifier(Notifier&) = 0;
virtual void did_post_event() = 0;
// FIXME: These APIs only exist for obscure use-cases inside SerenityOS. Try to get rid of them.
virtual void unquit() = 0;
virtual bool was_exit_requested() const = 0;
virtual void notify_forked_and_in_child() = 0;
virtual int register_signal(int signal_number, Function<void(int)> handler) = 0;
virtual void unregister_signal(int handler_id) = 0;
protected:
EventLoopImplementation();
ThreadEventQueue& m_thread_event_queue;
};
}