RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 19:57:35 +00:00
Code Issues Activity Actions

LibGUI: Set LinkLabel tooltip if text can't fit the widget

Browse source 
We were setting a tooltip when the text overflowed the *window* width,
make this more general by basing it on the *widget* width.
This commit is contained in:
Andreas Kling 2020-12-26 13:17:57 +01:00
parent 4e084793df
commit 7babe5ade6
2 changed files with 21 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

26
Libraries/LibGUI/LinkLabel.cpp
View file

@ -39,8 +39,9 @@ LinkLabel::LinkLabel(String text)
set_foreground_role(Gfx::ColorRole::Link); set_foreground_role(Gfx::ColorRole::Link);
} }
void LinkLabel::mousedown_event(MouseEvent&) void LinkLabel::mousedown_event(MouseEvent& event)
{ {
Label::mousedown_event(event);
if (on_click) { if (on_click) {
on_click(); on_click();
} }
@ -56,32 +57,39 @@ void LinkLabel::paint_event(PaintEvent& event)
Widget::palette().link()); Widget::palette().link());
} }
void LinkLabel::enter_event(Core::Event&) void LinkLabel::enter_event(Core::Event& event)
{ {
Label::enter_event(event);
m_hovered = true; m_hovered = true;
update(); update();
} }
void LinkLabel::leave_event(Core::Event&) void LinkLabel::leave_event(Core::Event& event)
{ {
Label::leave_event(event);
m_hovered = false; m_hovered = false;
update(); update();
} }
void LinkLabel::second_paint_event(PaintEvent&) void LinkLabel::did_change_text()
{ {
if (window()->width() < font().width(text())) { Label::did_change_text();
set_tooltip(text()); update_tooltip_if_needed();
}
} }
void LinkLabel::resize_event(ResizeEvent&) void LinkLabel::update_tooltip_if_needed()
{ {
if (window()->width() < font().width(text())) { if (width() < font().width(text())) {
set_tooltip(text()); set_tooltip(text());
} else { } else {
set_tooltip({}); set_tooltip({});
} }
} }
void LinkLabel::resize_event(ResizeEvent& event)
{
Label::resize_event(event);
update_tooltip_if_needed();
}
} }

5
Libraries/LibGUI/LinkLabel.h
View file

@ -42,10 +42,13 @@ private:
virtual void mousedown_event(MouseEvent&) override; virtual void mousedown_event(MouseEvent&) override;
virtual void paint_event(PaintEvent&) override; virtual void paint_event(PaintEvent&) override;
virtual void resize_event(ResizeEvent&) override; virtual void resize_event(ResizeEvent&) override;
virtual void second_paint_event(PaintEvent&) override;
virtual void enter_event(Core::Event&) override; virtual void enter_event(Core::Event&) override;
virtual void leave_event(Core::Event&) override; virtual void leave_event(Core::Event&) override;
virtual void did_change_text() override;
void update_tooltip_if_needed();
bool m_hovered { false }; bool m_hovered { false };
}; };