RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 21:57:43 +00:00
Code Issues Activity Actions

Take StringView in more places

Browse source 
We should work towards a pattern where we take StringView as function
arguments, and store String as member, to push the String construction
to the last possible moment.
This commit is contained in:
Robin Burchell 2019-06-02 12:26:28 +02:00 • committed by Andreas Kling
parent b55b6cd7fc
commit 7bce096afd
14 changed files with 28 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

10
AK/String.cpp
View file

@ -175,7 +175,7 @@ String String::format(const char* fmt, ...)
return builder.to_string();
}
bool String::ends_with(const String& str) const
bool String::ends_with(const StringView& str) const
{
if (str.is_empty())
return true;
@ -196,20 +196,20 @@ String String::repeated(char ch, int count)
return *impl;
}
bool String::matches(const String& mask, CaseSensitivity case_sensitivity) const
bool String::matches(const StringView& mask, CaseSensitivity case_sensitivity) const
{
if (case_sensitivity == CaseSensitivity::CaseInsensitive) {
String this_lower = this->to_lowercase();
String mask_lower = mask.to_lowercase();
String mask_lower = String(mask).to_lowercase();
return this_lower.match_helper(mask_lower);
}
return match_helper(mask);
}
bool String::match_helper(const String& mask) const
bool String::match_helper(const StringView& mask) const
{
if (is_null() || mask.is_null())
if (is_null())
return false;
const char* string_ptr = characters();