1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 06:47:34 +00:00

LibJS+LibWeb: Wrap raw JS::Cell*/& fields in GCPtr/NonnullGCPtr

This commit is contained in:
Matthew Olsson 2023-02-26 16:09:02 -07:00 committed by Andreas Kling
parent 1df3652e27
commit 7c0c1c8f49
214 changed files with 825 additions and 827 deletions

View file

@ -77,14 +77,14 @@ private:
virtual void visit_edges(Visitor&) override;
String m_locale; // [[Locale]]
Usage m_usage { Usage::Sort }; // [[Usage]]
Sensitivity m_sensitivity { Sensitivity::Variant }; // [[Sensitivity]]
CaseFirst m_case_first { CaseFirst::False }; // [[CaseFirst]]
String m_collation; // [[Collation]]
bool m_ignore_punctuation { false }; // [[IgnorePunctuation]]
bool m_numeric { false }; // [[Numeric]]
CollatorCompareFunction* m_bound_compare { nullptr }; // [[BoundCompare]]
String m_locale; // [[Locale]]
Usage m_usage { Usage::Sort }; // [[Usage]]
Sensitivity m_sensitivity { Sensitivity::Variant }; // [[Sensitivity]]
CaseFirst m_case_first { CaseFirst::False }; // [[CaseFirst]]
String m_collation; // [[Collation]]
bool m_ignore_punctuation { false }; // [[IgnorePunctuation]]
bool m_numeric { false }; // [[Numeric]]
GCPtr<CollatorCompareFunction> m_bound_compare; // [[BoundCompare]]
};
}

View file

@ -71,7 +71,7 @@ ThrowCompletionOr<Value> CollatorCompareFunction::call()
void CollatorCompareFunction::visit_edges(Visitor& visitor)
{
Base::visit_edges(visitor);
visitor.visit(&m_collator);
visitor.visit(m_collator);
}
}

View file

@ -26,7 +26,7 @@ private:
virtual void visit_edges(Visitor&) override;
Collator& m_collator; // [[Collator]]
NonnullGCPtr<Collator> m_collator; // [[Collator]]
};
double compare_strings(Collator&, Utf8View const& x, Utf8View const& y);

View file

@ -142,7 +142,7 @@ private:
Optional<Style> m_date_style; // [[DateStyle]]
Optional<Style> m_time_style; // [[TimeStyle]]
Vector<::Locale::CalendarRangePattern> m_range_patterns; // [[RangePatterns]]
NativeFunction* m_bound_format { nullptr }; // [[BoundFormat]]
GCPtr<NativeFunction> m_bound_format; // [[BoundFormat]]
String m_data_locale;
};

View file

@ -67,7 +67,7 @@ ThrowCompletionOr<Value> DateTimeFormatFunction::call()
void DateTimeFormatFunction::visit_edges(Cell::Visitor& visitor)
{
Base::visit_edges(visitor);
visitor.visit(&m_date_time_format);
visitor.visit(m_date_time_format);
}
}

View file

@ -28,7 +28,7 @@ private:
virtual void visit_edges(Visitor&) override;
DateTimeFormat& m_date_time_format; // [[DateTimeFormat]]
NonnullGCPtr<DateTimeFormat> m_date_time_format; // [[DateTimeFormat]]
};
}

View file

@ -251,7 +251,7 @@ private:
Notation m_notation { Notation::Invalid }; // [[Notation]]
Optional<CompactDisplay> m_compact_display {}; // [[CompactDisplay]]
SignDisplay m_sign_display { SignDisplay::Invalid }; // [[SignDisplay]]
NativeFunction* m_bound_format { nullptr }; // [[BoundFormat]]
GCPtr<NativeFunction> m_bound_format; // [[BoundFormat]]
// Non-standard. Stores the resolved currency display string based on [[Locale]], [[Currency]], and [[CurrencyDisplay]].
Optional<StringView> m_resolved_currency_display;

View file

@ -54,7 +54,7 @@ ThrowCompletionOr<Value> NumberFormatFunction::call()
void NumberFormatFunction::visit_edges(Cell::Visitor& visitor)
{
Base::visit_edges(visitor);
visitor.visit(&m_number_format);
visitor.visit(m_number_format);
}
}

View file

@ -28,7 +28,7 @@ private:
virtual void visit_edges(Visitor&) override;
NumberFormat& m_number_format; // [[NumberFormat]]
NonnullGCPtr<NumberFormat> m_number_format; // [[NumberFormat]]
};
}

View file

@ -68,8 +68,8 @@ private:
String m_numbering_system; // [[NumberingSystem]]
::Locale::Style m_style { ::Locale::Style::Long }; // [[Style]]
Numeric m_numeric { Numeric::Always }; // [[Numeric]]
NumberFormat* m_number_format { nullptr }; // [[NumberFormat]]
PluralRules* m_plural_rules { nullptr }; // [[PluralRules]]
GCPtr<NumberFormat> m_number_format; // [[NumberFormat]]
GCPtr<PluralRules> m_plural_rules; // [[PluralRules]]
};
struct PatternPartitionWithUnit : public PatternPartition {

View file

@ -34,8 +34,8 @@ SegmentIterator::SegmentIterator(Realm& realm, Segmenter& segmenter, Utf16View c
void SegmentIterator::visit_edges(Cell::Visitor& visitor)
{
Base::visit_edges(visitor);
visitor.visit(&m_iterating_segmenter);
visitor.visit(&m_segments);
visitor.visit(m_iterating_segmenter);
visitor.visit(m_segments);
}
}

View file

@ -32,11 +32,11 @@ private:
virtual void visit_edges(Cell::Visitor&) override;
Segmenter& m_iterating_segmenter; // [[IteratingSegmenter]]
NonnullGCPtr<Segmenter> m_iterating_segmenter; // [[IteratingSegmenter]]
Utf16View m_iterated_string; // [[IteratedString]]
size_t m_iterated_string_next_segment_code_unit_index { 0 }; // [[IteratedStringNextSegmentCodeUnitIndex]]
Segments const& m_segments;
NonnullGCPtr<Segments const> m_segments;
};
}

View file

@ -32,7 +32,7 @@ Segments::Segments(Realm& realm, Segmenter& segmenter, Utf16String string)
void Segments::visit_edges(Cell::Visitor& visitor)
{
Base::visit_edges(visitor);
visitor.visit(&m_segments_segmenter);
visitor.visit(m_segments_segmenter);
}
}

View file

@ -29,8 +29,8 @@ private:
virtual void visit_edges(Cell::Visitor&) override;
Segmenter& m_segments_segmenter; // [[SegmentsSegmenter]]
Utf16String m_segments_string; // [[SegmentsString]]
NonnullGCPtr<Segmenter> m_segments_segmenter; // [[SegmentsSegmenter]]
Utf16String m_segments_string; // [[SegmentsString]]
};
}