RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 00:57:44 +00:00
Code Issues Activity Actions

LibJS+LibWeb: Wrap raw JS::Cell*/& fields in GCPtr/NonnullGCPtr

Browse source
This commit is contained in:
Matthew Olsson 2023-02-26 16:09:02 -07:00 • committed by Andreas Kling
parent 1df3652e27
commit 7c0c1c8f49
214 changed files with 825 additions and 827 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/Loader/FrameLoader.cpp
View file

@ -207,7 +207,7 @@ bool FrameLoader::load(LoadRequest& request, Type type)
return false;
}
if (!m_browsing_context.is_frame_nesting_allowed(request.url())) {
if (!m_browsing_context->is_frame_nesting_allowed(request.url())) {
dbgln("No further recursion is allowed for the frame, abort load!");
return false;
}
@ -216,7 +216,7 @@ bool FrameLoader::load(LoadRequest& request, Type type)
if (type == Type::Navigation || type == Type::Reload || type == Type::Redirect) {
if (auto* page = browsing_context().page()) {
if (&page->top_level_browsing_context() == &m_browsing_context)
if (&page->top_level_browsing_context() == m_browsing_context)
page->client().page_did_start_loading(url, type == Type::Redirect);
}
}

2
Userland/Libraries/LibWeb/Loader/FrameLoader.h
View file

@ -47,7 +47,7 @@ private:
void load_favicon(RefPtr<Gfx::Bitmap> bitmap = nullptr);
bool parse_document(DOM::Document&, ByteBuffer const& data);
HTML::BrowsingContext& m_browsing_context;
JS::NonnullGCPtr<HTML::BrowsingContext> m_browsing_context;
size_t m_redirects_count { 0 };
};

2
Userland/Libraries/LibWeb/Loader/ImageLoader.cpp
View file

@ -36,7 +36,7 @@ void ImageLoader::load_without_resetting_redirect_counter(AK::URL const& url)
{
m_loading_state = LoadingState::Loading;
auto request = LoadRequest::create_for_url_on_page(url, m_owner_element.document().page());
auto request = LoadRequest::create_for_url_on_page(url, m_owner_element->document().page());
set_resource(ResourceLoader::the().load_resource(Resource::Type::Image, request));
}

2
Userland/Libraries/LibWeb/Loader/ImageLoader.h
View file

@ -53,7 +53,7 @@ private:
Failed,
};
DOM::Element& m_owner_element;
JS::NonnullGCPtr<DOM::Element> m_owner_element;
mutable bool m_visible_in_viewport { false };