RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 13:07:46 +00:00
Code Issues Activity Actions

LibGUI: Check that AutocompleteBox's selection row is valid

Browse source 
Previously we didn't check that the selection's row index is in a valid
range before attempting to access its data via the model.

This could cause an out-of-bounds access to the model's Vector of
suggestions.

I think this should fix #7404, but I can't verify it does because
I wasn't able to reproduce it on my machine.
This commit is contained in:
Itamar 2021-05-24 22:54:23 +03:00 • committed by Andreas Kling
parent 7a4445a1fe
commit 7c2941d4ea
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibGUI/AutocompleteProvider.cpp
View file

@ -168,7 +168,7 @@ void AutocompleteBox::apply_suggestion()
return; return;
auto selected_index = m_suggestion_view->selection().first(); auto selected_index = m_suggestion_view->selection().first();
if (!selected_index.is_valid()) if (!selected_index.is_valid() || !m_suggestion_view->model()->is_valid(selected_index))
return; return;
auto suggestion_index = m_suggestion_view->model()->index(selected_index.row(), AutocompleteSuggestionModel::Column::Name); auto suggestion_index = m_suggestion_view->model()->index(selected_index.row(), AutocompleteSuggestionModel::Column::Name);