RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 12:07:45 +00:00
Code Issues Activity Actions

LibJS: Pass Realm to GlobalObject::initialize_global_object()

Browse source 
Global object initialization is tightly coupled to realm creation, so
simply pass it to the function instead of relying on the non-standard
'associated realm' concept, which I'd like to remove later.

This works essentially the same way as regular Object::initialize() now.

Additionally this allows us to forward the realm to GlobalObject's
add_constructor() / initialize_constructor() helpers, so they set the
correct realm on the allocated constructor function object.
This commit is contained in:
Linus Groh 2022-08-22 18:56:16 +01:00
parent b465f46e00
commit 7c468b5a77
18 changed files with 76 additions and 79 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibTest/JavaScriptTestRunner.h
View file

@ -197,12 +197,12 @@ public:
virtual ~TestRunnerGlobalObject() override = default;
virtual void initialize_global_object() override;
virtual void initialize_global_object(JS::Realm&) override;
};
inline void TestRunnerGlobalObject::initialize_global_object()
inline void TestRunnerGlobalObject::initialize_global_object(JS::Realm& realm)
{
Base::initialize_global_object();
Base::initialize_global_object(realm);
define_direct_property("global", this, JS::Attribute::Enumerable);
for (auto& entry : s_exposed_global_functions) {
define_native_function(