mirror of
https://github.com/RGBCube/serenity
synced 2025-07-28 23:17:45 +00:00
LibJS: Pass Realm to GlobalObject::initialize_global_object()
Global object initialization is tightly coupled to realm creation, so simply pass it to the function instead of relying on the non-standard 'associated realm' concept, which I'd like to remove later. This works essentially the same way as regular Object::initialize() now. Additionally this allows us to forward the realm to GlobalObject's add_constructor() / initialize_constructor() helpers, so they set the correct realm on the allocated constructor function object.
This commit is contained in:
parent
b465f46e00
commit
7c468b5a77
18 changed files with 76 additions and 79 deletions
|
@ -57,14 +57,12 @@ WindowObject::WindowObject(JS::Realm& realm, HTML::Window& impl)
|
|||
impl.set_wrapper({}, *this);
|
||||
}
|
||||
|
||||
void WindowObject::initialize_global_object()
|
||||
void WindowObject::initialize_global_object(JS::Realm& realm)
|
||||
{
|
||||
Base::initialize_global_object();
|
||||
Base::initialize_global_object(realm);
|
||||
|
||||
Object::set_prototype(&ensure_web_prototype<WindowPrototype>("Window"));
|
||||
|
||||
auto& realm = *associated_realm();
|
||||
|
||||
// FIXME: These should be native accessors, not properties
|
||||
define_direct_property("window", this, JS::Attribute::Enumerable);
|
||||
define_direct_property("frames", this, JS::Attribute::Enumerable);
|
||||
|
|
|
@ -33,7 +33,7 @@ class WindowObject
|
|||
|
||||
public:
|
||||
explicit WindowObject(JS::Realm&, HTML::Window&);
|
||||
virtual void initialize_global_object() override;
|
||||
virtual void initialize_global_object(JS::Realm&) override;
|
||||
virtual ~WindowObject() override = default;
|
||||
|
||||
HTML::Window& impl() { return *m_impl; }
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue