1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-18 21:25:07 +00:00

LibJS: Rework how native functions are called to improve |this| value

Native functions now only get the Interpreter& as an argument. They can
then extract |this| along with any indexed arguments it wants from it.

This forces functions that want |this| to actually deal with calling
interpreter.this_value().to_object(), and dealing with the possibility
of a non-object |this|.

This is still not great but let's keep massaging it forward.
This commit is contained in:
Andreas Kling 2020-03-28 22:48:35 +01:00
parent c209ea1985
commit 7c4e53f31e
25 changed files with 145 additions and 102 deletions

View file

@ -190,7 +190,7 @@ Value Interpreter::call(Function* function, Value this_value, const Vector<Value
auto& call_frame = push_call_frame();
call_frame.this_value = this_value;
call_frame.arguments = arguments;
auto result = function->call(*this, call_frame.arguments);
auto result = function->call(*this);
pop_call_frame();
return result;
}