RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-20 14:35:07 +00:00
Code Issues Activity Actions

LibJS: Rework how native functions are called to improve |this| value

Browse source 
Native functions now only get the Interpreter& as an argument. They can
then extract |this| along with any indexed arguments it wants from it.

This forces functions that want |this| to actually deal with calling
interpreter.this_value().to_object(), and dealing with the possibility
of a non-object |this|.

This is still not great but let's keep massaging it forward.
This commit is contained in:
Andreas Kling 2020-03-28 22:48:35 +01:00
parent c209ea1985
commit 7c4e53f31e
25 changed files with 145 additions and 102 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Libraries/LibJS/Runtime/NativeFunction.cpp
View file

@ -30,7 +30,7 @@
namespace JS {
NativeFunction::NativeFunction(AK::Function<Value(Object*, const Vector<Value>&)> native_function)
NativeFunction::NativeFunction(AK::Function<Value(Interpreter&)> native_function)
: m_native_function(move(native_function))
{
}
@ -39,14 +39,9 @@ NativeFunction::~NativeFunction()
{
}
Value NativeFunction::call(Interpreter& interpreter, const Vector<Value>& arguments)
Value NativeFunction::call(Interpreter& interpreter)
{
auto this_value = interpreter.this_value();
// FIXME: Why are we here with a non-object 'this'?
Object* this_object = nullptr;
if (this_value.is_object())
this_object = this_value.as_object();
return m_native_function(this_object, arguments);
return m_native_function(interpreter);
}
}