RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 00:47:36 +00:00
Code Issues Activity Actions

LibJS: Rework how native functions are called to improve |this| value

Browse source 
Native functions now only get the Interpreter& as an argument. They can
then extract |this| along with any indexed arguments it wants from it.

This forces functions that want |this| to actually deal with calling
interpreter.this_value().to_object(), and dealing with the possibility
of a non-object |this|.

This is still not great but let's keep massaging it forward.
This commit is contained in:
Andreas Kling 2020-03-28 22:48:35 +01:00
parent c209ea1985
commit 7c4e53f31e
25 changed files with 145 additions and 102 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Libraries/LibJS/Runtime/NativeFunction.h
View file

@ -33,10 +33,10 @@ namespace JS {
class NativeFunction : public Function {
public:
explicit NativeFunction(AK::Function<Value(Object*, const Vector<Value>&)>);
explicit NativeFunction(AK::Function<Value(Interpreter&)>);
virtual ~NativeFunction() override;
virtual Value call(Interpreter&, const Vector<Value>&) override;
virtual Value call(Interpreter&) override;
protected:
NativeFunction() {}
@ -45,7 +45,7 @@ private:
virtual bool is_native_function() const override { return true; }
virtual const char* class_name() const override { return "NativeFunction"; }
AK::Function<Value(Object*, const Vector<Value>&)> m_native_function;
AK::Function<Value(Interpreter&)> m_native_function;
};
}