RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 18:57:45 +00:00
Code Issues Activity Actions

LibWeb: Make BrowsingContextGroup store Page member as NonnullGCPtr

Browse source 
No need to use WeakPtr anymore.
This commit is contained in:
Andreas Kling 2023-06-26 06:56:54 +02:00
parent 289ea2db9c
commit 7c926d04b7
2 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Userland/Libraries/LibWeb/HTML/BrowsingContextGroup.cpp
View file

@ -34,6 +34,7 @@ BrowsingContextGroup::~BrowsingContextGroup()
void BrowsingContextGroup::visit_edges(Cell::Visitor& visitor) void BrowsingContextGroup::visit_edges(Cell::Visitor& visitor)
{ {
Base::visit_edges(visitor); Base::visit_edges(visitor);
visitor.visit(m_page);
for (auto& context : m_browsing_context_set) for (auto& context : m_browsing_context_set)
visitor.visit(context); visitor.visit(context);
} }

2
Userland/Libraries/LibWeb/HTML/BrowsingContextGroup.h
View file

@ -43,7 +43,7 @@ private:
// https://html.spec.whatwg.org/multipage/browsers.html#browsing-context-group-set // https://html.spec.whatwg.org/multipage/browsers.html#browsing-context-group-set
OrderedHashTable<JS::NonnullGCPtr<BrowsingContext>> m_browsing_context_set; OrderedHashTable<JS::NonnullGCPtr<BrowsingContext>> m_browsing_context_set;
WeakPtr<Page> m_page; JS::NonnullGCPtr<Page> m_page;
}; };
} }