RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-18 01:05:07 +00:00
Code Issues Activity Actions

Libraries: Use default constructors/destructors in LibSyntax

Browse source 
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
This commit is contained in:
Lenny Maiorani 2022-03-04 13:26:19 -07:00 • committed by Andreas Kling
parent 7abb782206
commit 7cc6ba16be
2 changed files with 3 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibSyntax/Highlighter.cpp
View file

@ -1,5 +1,5 @@
/* /*
* Copyright (c) 2020-2021, the SerenityOS developers. * Copyright (c) 2020-2022, the SerenityOS developers.
* *
* SPDX-License-Identifier: BSD-2-Clause * SPDX-License-Identifier: BSD-2-Clause
*/ */
@ -10,10 +10,6 @@
namespace Syntax { namespace Syntax {
Highlighter::~Highlighter()
{
}
void Highlighter::highlight_matching_token_pair() void Highlighter::highlight_matching_token_pair()
{ {
auto& document = m_client->get_document(); auto& document = m_client->get_document();

4
Userland/Libraries/LibSyntax/Highlighter.h
View file

@ -37,7 +37,7 @@ class Highlighter {
AK_MAKE_NONMOVABLE(Highlighter); AK_MAKE_NONMOVABLE(Highlighter);
public: public:
virtual ~Highlighter(); virtual ~Highlighter() = default;
virtual Language language() const = 0; virtual Language language() const = 0;
StringView language_string(Language) const; StringView language_string(Language) const;
@ -64,7 +64,7 @@ public:
virtual bool is_cpp_semantic_highlighter() const { return false; } virtual bool is_cpp_semantic_highlighter() const { return false; }
protected: protected:
Highlighter() { } Highlighter() = default;
// FIXME: This should be WeakPtr somehow // FIXME: This should be WeakPtr somehow
HighlighterClient* m_client { nullptr }; HighlighterClient* m_client { nullptr };