RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 20:12:43 +00:00
Code Issues Activity Actions

Userland: Fix unnecessary heap allocation of singleton objects

Browse source 
In order to avoid having multiple instances, we were keeping a pointer
to these singleton objects and only allocating them when it was null.

We have `__cxa_guard_{acquire,release}` in the userland, so there's no
need to do this dance, as the compiler will ensure that the constructors
are only called once.
This commit is contained in:
Daniel Bertalan 2022-01-28 21:22:13 +01:00 • committed by Andreas Kling
parent c1184c1fde
commit 7d11edbe17
9 changed files with 18 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/Loader/ContentFilter.cpp
View file

@ -11,8 +11,8 @@ namespace Web {
ContentFilter& ContentFilter::the()
{
static ContentFilter* filter = new ContentFilter;
return *filter;
static ContentFilter filter;
return filter;
}
ContentFilter::ContentFilter()