From 7d4e3f01ddb001764b872e2fb448c61c2895abe9 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Mon, 26 Jul 2021 02:56:02 +0200 Subject: [PATCH] Taskbar: Unbreak application launchers in the start menu Application launcher actions reference their applications by an index into the global `g_apps` table. When skipping over settings apps, we still have to increment the current app identifier. --- Userland/Services/Taskbar/main.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Userland/Services/Taskbar/main.cpp b/Userland/Services/Taskbar/main.cpp index c7d1291c59..9dc465f9d1 100644 --- a/Userland/Services/Taskbar/main.cpp +++ b/Userland/Services/Taskbar/main.cpp @@ -166,8 +166,10 @@ NonnullRefPtr build_system_menu() // Then we create and insert all the app menu items into the right place. int app_identifier = 0; for (const auto& app : g_apps) { - if (app.category == "Settings"sv) + if (app.category == "Settings"sv) { + ++app_identifier; continue; + } auto icon = GUI::FileIconProvider::icon_for_executable(app.executable).bitmap_for_size(16);