RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 12:07:45 +00:00
Code Issues Activity Actions

LibJS: Implement Function.prototype.toString() according to the spec

Browse source 
That's an old yak :^)
No, past me, AST nodes do not need to learn to stringify themselves.
This is now massively simplified by using the [[SourceText]] internal
slot.

Also updates a bunch of tests that are incorrect due to the old
implementation not being spec compliant, and add plenty more.
This commit is contained in:
Linus Groh 2022-01-18 23:50:53 +00:00
parent 1ee7e97e24
commit 7d521b7c7c
3 changed files with 166 additions and 59 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibJS/Tests/builtins/Function/Function.js
View file

@ -33,7 +33,7 @@ describe("correct behavior", () => {
expect(new Function("-->")()).toBeUndefined();
expect(new Function().name).toBe("anonymous");
expect(new Function().toString()).toBe("function anonymous() {\n ???\n}");
expect(new Function().toString()).toBe("function anonymous(\n) {\n\n}");
});
});