diff --git a/Kernel/Locking/SpinLockProtected.h b/Kernel/Locking/SpinLockProtected.h index 143eb98133..34a09029a2 100644 --- a/Kernel/Locking/SpinLockProtected.h +++ b/Kernel/Locking/SpinLockProtected.h @@ -6,27 +6,46 @@ #pragma once -#include +#include namespace Kernel { template -class SpinLockProtected - : private T - , public SpinLockContendedResource { +class SpinLockProtected { AK_MAKE_NONCOPYABLE(SpinLockProtected); AK_MAKE_NONMOVABLE(SpinLockProtected); -protected: - using LockedConst = SpinLockLockedResource; - using LockedMutable = SpinLockLockedResource; +private: + template + class Locked { + AK_MAKE_NONCOPYABLE(Locked); + AK_MAKE_NONMOVABLE(Locked); - LockedConst lock_const() const { return LockedConst(static_cast(this), this->SpinLockContendedResource::m_spinlock); } - LockedMutable lock_mutable() { return LockedMutable(static_cast(this), this->SpinLockContendedResource::m_spinlock); } + public: + Locked(U& value, RecursiveSpinLock& spinlock) + : m_value(value) + , m_locker(spinlock) + { + } + + ALWAYS_INLINE U const* operator->() const { return &m_value; } + ALWAYS_INLINE U const& operator*() const { return m_value; } + + ALWAYS_INLINE U* operator->() { return &m_value; } + ALWAYS_INLINE U& operator*() { return m_value; } + + ALWAYS_INLINE U const& get() const { return m_value; } + ALWAYS_INLINE U& get() { return m_value; } + + private: + U& m_value; + ScopedSpinLock m_locker; + }; + + auto lock_const() const { return Locked(m_value, m_spinlock); } + auto lock_mutable() { return Locked(m_value, m_spinlock); } public: - using T::T; - SpinLockProtected() = default; template @@ -60,6 +79,10 @@ public: callback(item); }); } + +private: + T m_value; + RecursiveSpinLock mutable m_spinlock; }; } diff --git a/Kernel/Locking/SpinLockResource.h b/Kernel/Locking/SpinLockResource.h deleted file mode 100644 index f8d23b5da0..0000000000 --- a/Kernel/Locking/SpinLockResource.h +++ /dev/null @@ -1,53 +0,0 @@ -/* - * Copyright (c) 2021, the SerenityOS developers. - * - * SPDX-License-Identifier: BSD-2-Clause - */ - -#pragma once - -#include -#include - -namespace Kernel { - -template -class SpinLockLockedResource { - AK_MAKE_NONCOPYABLE(SpinLockLockedResource); - -public: - SpinLockLockedResource(T* value, RecursiveSpinLock& spinlock) - : m_value(value) - , m_scoped_spinlock(spinlock) - { - } - - ALWAYS_INLINE T const* operator->() const { return m_value; } - ALWAYS_INLINE T const& operator*() const { return *m_value; } - - ALWAYS_INLINE T* operator->() { return m_value; } - ALWAYS_INLINE T& operator*() { return *m_value; } - - ALWAYS_INLINE T const* get() const { return m_value; } - ALWAYS_INLINE T* get() { return m_value; } - -private: - T* m_value; - ScopedSpinLock m_scoped_spinlock; -}; - -class SpinLockContendedResource { - template - friend class SpinLockLockedResource; - - AK_MAKE_NONCOPYABLE(SpinLockContendedResource); - AK_MAKE_NONMOVABLE(SpinLockContendedResource); - -public: - SpinLockContendedResource() = default; - -protected: - mutable RecursiveSpinLock m_spinlock; -}; - -}