RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 11:18:11 +00:00
Code Issues Activity Actions

LibELF: Remove unused m_program_interpreter member from DynamicLoader

Browse source 
While profiling I realized that this member is unused, so the
StringBuilder and String allocation are completely un-necessary.
This commit is contained in:
Brian Gianforcaro 2022-03-31 00:29:56 -07:00 • committed by Andreas Kling
parent 39f924a731
commit 7d667b9f69
3 changed files with 2 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibELF/DynamicLoader.cpp
View file

@ -122,11 +122,9 @@ bool DynamicLoader::validate()
auto* elf_header = (ElfW(Ehdr)*)m_file_data;
if (!validate_elf_header(*elf_header, m_file_size))
return false;
StringBuilder interpreter_path_builder;
auto result_or_error = validate_program_headers(*elf_header, m_file_size, { m_file_data, m_file_size }, &interpreter_path_builder);
auto result_or_error = validate_program_headers(*elf_header, m_file_size, { m_file_data, m_file_size });
if (result_or_error.is_error() || !result_or_error.value())
return false;
m_program_interpreter = interpreter_path_builder.string_view();
return true;
}