From 7d757fefeb1a96eb540979b09b9b81a56dc70984 Mon Sep 17 00:00:00 2001 From: Aliaksandr Kalenik Date: Sat, 16 Dec 2023 15:53:29 +0100 Subject: [PATCH] LibWeb: Remove FIXME if paintable is missing in getBoundingClientRect() We should not print FIXME when paintable is missing (display: none) because that means actually we can't to get a rect. --- Userland/Libraries/LibWeb/DOM/Element.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Userland/Libraries/LibWeb/DOM/Element.cpp b/Userland/Libraries/LibWeb/DOM/Element.cpp index e416668ed5..df276a5f29 100644 --- a/Userland/Libraries/LibWeb/DOM/Element.cpp +++ b/Userland/Libraries/LibWeb/DOM/Element.cpp @@ -852,7 +852,10 @@ JS::NonnullGCPtr Element::get_bounding_client_rect() const return Geometry::DOMRect::create(realm(), absolute_rect.to_type()); } - dbgln("FIXME: Failed to get bounding client rect for element ({})", debug_description()); + if (paintable) { + dbgln("FIXME: Failed to get bounding client rect for element ({})", debug_description()); + } + return Geometry::DOMRect::construct_impl(realm(), 0, 0, 0, 0).release_value_but_fixme_should_propagate_errors(); }