RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 18:27:39 +00:00
Code Issues Activity Actions

LibWeb: Use a JS::NonnullGCPtr for DOMTokenList::m_associated_element

Browse source 
Both Element and DOMTokenList are GC-allocated objects so they can just
mark each other instead of using the old strong/weak pattern we use in
ref-counting ownership models.
This commit is contained in:
Andreas Kling 2023-01-01 15:32:48 +01:00
parent 59d9d1d07a
commit 7d863174b3
2 changed files with 9 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/DOM/DOMTokenList.h
View file

@ -45,10 +45,12 @@ public:
private:
DOMTokenList(Element const& associated_element, FlyString associated_attribute);
virtual void visit_edges(Cell::Visitor&) override;
WebIDL::ExceptionOr<void> validate_token(StringView token) const;
void run_update_steps();
WeakPtr<Element> m_associated_element;
JS::NonnullGCPtr<Element> m_associated_element;
FlyString m_associated_attribute;
Vector<DeprecatedString> m_token_set;
};