RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-22 17:15:08 +00:00
Code Issues Activity Actions

LibGUI: Rewrite layout system in terms of min and max sizes

Browse source 
This patch removes size policies and preferred sizes, and replaces them
with min-size and max-size for each widget.

Box layout now works in 3 passes:

    1) Set all items (widgets/spacers) to their min-size
    2) Distribute remaining space evenly, respecting max-size
    3) Place widgets one after the other, adding spacing in between

I've also added convenience helpers for setting a fixed size (which is
the same as setting min-size and max-size to the same value.)

This significantly reduces the verbosity of widget layout and makes GML
a bit more pleasant to write, too. :^)
This commit is contained in:
Andreas Kling 2020-12-30 01:23:32 +01:00
parent b2bba5ce5c
commit 7dc5a3ead8
83 changed files with 444 additions and 957 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Libraries/LibGUI/ImageWidget.cpp
View file

@ -39,7 +39,6 @@ ImageWidget::ImageWidget(const StringView&)
set_frame_thickness(0);
set_frame_shadow(Gfx::FrameShadow::Plain);
set_frame_shape(Gfx::FrameShape::NoFrame);
set_size_policy(GUI::SizePolicy::Fixed, GUI::SizePolicy::Fixed);
set_auto_resize(true);
}
@ -54,7 +53,7 @@ void ImageWidget::set_bitmap(const Gfx::Bitmap* bitmap)
m_bitmap = bitmap;
if (m_bitmap && m_auto_resize)
set_preferred_size(m_bitmap->width(), m_bitmap->height());
set_fixed_size(m_bitmap->size());
update();
}
@ -64,7 +63,7 @@ void ImageWidget::set_auto_resize(bool value)
m_auto_resize = value;
if (m_bitmap)
set_preferred_size(m_bitmap->width(), m_bitmap->height());
set_fixed_size(m_bitmap->size());
}
void ImageWidget::animate()