diff --git a/Userland/Libraries/LibJS/Parser.cpp b/Userland/Libraries/LibJS/Parser.cpp index 0eb7352a17..56483b9866 100644 --- a/Userland/Libraries/LibJS/Parser.cpp +++ b/Userland/Libraries/LibJS/Parser.cpp @@ -886,7 +886,7 @@ NonnullRefPtr Parser::parse_array_expression() return create_ast_node({ rule_start.position(), position() }, move(elements)); } -NonnullRefPtr Parser::parse_string_literal(Token token, bool in_template_literal) +NonnullRefPtr Parser::parse_string_literal(const Token& token, bool in_template_literal) { auto rule_start = push_start(); auto status = Token::StringValueStatus::Ok; @@ -974,7 +974,7 @@ NonnullRefPtr Parser::parse_template_literal(bool is_tagged) return create_ast_node({ rule_start.position(), position() }, expressions); } -NonnullRefPtr Parser::parse_expression(int min_precedence, Associativity associativity, Vector forbidden) +NonnullRefPtr Parser::parse_expression(int min_precedence, Associativity associativity, const Vector& forbidden) { auto rule_start = push_start(); auto expression = parse_primary_expression(); @@ -1844,7 +1844,7 @@ bool Parser::match_unary_prefixed_expression() const || type == TokenType::Delete; } -bool Parser::match_secondary_expression(Vector forbidden) const +bool Parser::match_secondary_expression(const Vector& forbidden) const { auto type = m_parser_state.m_current_token.type(); if (forbidden.contains_slow(type)) diff --git a/Userland/Libraries/LibJS/Parser.h b/Userland/Libraries/LibJS/Parser.h index 628c90803b..6743e1cb75 100644 --- a/Userland/Libraries/LibJS/Parser.h +++ b/Userland/Libraries/LibJS/Parser.h @@ -83,13 +83,13 @@ public: NonnullRefPtr parse_with_statement(); NonnullRefPtr parse_debugger_statement(); NonnullRefPtr parse_conditional_expression(NonnullRefPtr test); - NonnullRefPtr parse_expression(int min_precedence, Associativity associate = Associativity::Right, Vector forbidden = {}); + NonnullRefPtr parse_expression(int min_precedence, Associativity associate = Associativity::Right, const Vector& forbidden = {}); NonnullRefPtr parse_primary_expression(); NonnullRefPtr parse_unary_prefixed_expression(); NonnullRefPtr parse_regexp_literal(); NonnullRefPtr parse_object_expression(); NonnullRefPtr parse_array_expression(); - NonnullRefPtr parse_string_literal(Token token, bool in_template_literal = false); + NonnullRefPtr parse_string_literal(const Token& token, bool in_template_literal = false); NonnullRefPtr parse_template_literal(bool is_tagged); NonnullRefPtr parse_secondary_expression(NonnullRefPtr, int min_precedence, Associativity associate = Associativity::Right); NonnullRefPtr parse_call_expression(NonnullRefPtr); @@ -153,7 +153,7 @@ private: Associativity operator_associativity(TokenType) const; bool match_expression() const; bool match_unary_prefixed_expression() const; - bool match_secondary_expression(Vector forbidden = {}) const; + bool match_secondary_expression(const Vector& forbidden = {}) const; bool match_statement() const; bool match_declaration() const; bool match_variable_declaration() const;