From 7dfa5fc1dccbf094bd4753afa870ba20b84beddf Mon Sep 17 00:00:00 2001 From: Nico Weber Date: Sun, 23 Jul 2023 21:02:08 -0400 Subject: [PATCH] LibPDF: Make JPEG decoding errors not assert Instead, they're now turned into a diagnostic like other rendering problems, looking like so: Internal error while processing PDF file: Unsupported chroma subsampling factors Makes us no longer crash rendering page 1141 of pdf_reference_1.7-pdf. --- Userland/Libraries/LibPDF/Filter.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Userland/Libraries/LibPDF/Filter.cpp b/Userland/Libraries/LibPDF/Filter.cpp index 31574d3377..ba6ee988e4 100644 --- a/Userland/Libraries/LibPDF/Filter.cpp +++ b/Userland/Libraries/LibPDF/Filter.cpp @@ -271,7 +271,7 @@ PDFErrorOr Filter::decode_jbig2(ReadonlyBytes) PDFErrorOr Filter::decode_dct(ReadonlyBytes bytes) { if (Gfx::JPEGImageDecoderPlugin::sniff({ bytes.data(), bytes.size() })) { - auto decoder = Gfx::JPEGImageDecoderPlugin::create({ bytes.data(), bytes.size() }).release_value_but_fixme_should_propagate_errors(); + auto decoder = TRY(Gfx::JPEGImageDecoderPlugin::create({ bytes.data(), bytes.size() })); auto frame = TRY(decoder->frame(0)); return TRY(frame.image->serialize_to_byte_buffer()); }