RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 15:07:45 +00:00
Code Issues Activity Actions

LibJS: Rename ErrorType::IntlNumberIsNaN to ErrorType::NumberIsNaN

Browse source 
It will be used outside of the Intl namespace, so give it a less overly
specific name.
This commit is contained in:
Timothy Flynn 2023-06-25 10:11:37 -04:00 • committed by Andreas Kling
parent deeee65e37
commit 7e0083fb65
4 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibJS/Runtime/ErrorTypes.h
View file

@ -52,7 +52,6 @@
M(IntlInvalidTime, "Time value must be between -8.64E15 and 8.64E15") \
M(IntlInvalidUnit, "Unit {} is not a valid time unit") \
M(IntlMinimumExceedsMaximum, "Minimum value {} is larger than maximum value {}") \
M(IntlNumberIsNaN, "{} must not be NaN") \
M(IntlNumberIsNaNOrInfinity, "Number must not be NaN or Infinity") \
M(IntlNumberIsNaNOrOutOfRange, "Value {} is NaN or is not between {} and {}") \
M(IntlOptionUndefined, "Option {} must be defined when option {} is {}") \
@ -101,6 +100,7 @@
M(NotIterable, "{} is not iterable") \
M(NotObjectCoercible, "{} cannot be converted to an object") \
M(NotUndefined, "{} is not undefined") \
M(NumberIsNaN, "{} must not be NaN") \
M(ObjectDefineOwnPropertyReturnedFalse, "Object's [[DefineOwnProperty]] method returned false") \
M(ObjectDeleteReturnedFalse, "Object's [[Delete]] method returned false") \
M(ObjectFreezeFailed, "Could not freeze object") \

4
Userland/Libraries/LibJS/Runtime/Intl/NumberFormat.cpp
View file

@ -1793,9 +1793,9 @@ ThrowCompletionOr<Vector<PatternPartitionWithSource>> partition_number_range_pat
{
// 1. If x is NaN or y is NaN, throw a RangeError exception.
if (start.is_nan())
return vm.throw_completion<RangeError>(ErrorType::IntlNumberIsNaN, "start"sv);
return vm.throw_completion<RangeError>(ErrorType::NumberIsNaN, "start"sv);
if (end.is_nan())
return vm.throw_completion<RangeError>(ErrorType::IntlNumberIsNaN, "end"sv);
return vm.throw_completion<RangeError>(ErrorType::NumberIsNaN, "end"sv);
// 2. Let result be a new empty List.
Vector<PatternPartitionWithSource> result;

4
Userland/Libraries/LibJS/Runtime/Intl/PluralRules.cpp
View file

@ -147,9 +147,9 @@ ThrowCompletionOr<::Locale::PluralCategory> resolve_plural_range(VM& vm, PluralR
// 5. If x is NaN or y is NaN, throw a RangeError exception.
if (start.is_nan())
return vm.throw_completion<RangeError>(ErrorType::IntlNumberIsNaN, "start"sv);
return vm.throw_completion<RangeError>(ErrorType::NumberIsNaN, "start"sv);
if (end.is_nan())
return vm.throw_completion<RangeError>(ErrorType::IntlNumberIsNaN, "end"sv);
return vm.throw_completion<RangeError>(ErrorType::NumberIsNaN, "end"sv);
// 6. Let xp be ! ResolvePlural(pluralRules, x).
auto start_plurality = MUST_OR_THROW_OOM(resolve_plural(vm, plural_rules, start));

2
Userland/Libraries/LibJS/Runtime/SetPrototype.cpp
View file

@ -224,7 +224,7 @@ static ThrowCompletionOr<SetRecord> get_set_record(VM& vm, Value value)
// 4. NOTE: If rawSize is undefined, then numSize will be NaN.
// 5. If numSize is NaN, throw a TypeError exception.
if (number_size.is_nan())
return vm.throw_completion<TypeError>(ErrorType::IntlNumberIsNaN, "size"sv);
return vm.throw_completion<TypeError>(ErrorType::NumberIsNaN, "size"sv);
// 6. Let intSize be ! ToIntegerOrInfinity(numSize).
auto integer_size = MUST(number_size.to_integer_or_infinity(vm));